Skip RBS rewrite for files without RBS comments#2612
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip RBS source rewriting for typed Ruby files that do not contain RBS comment markers.
Tapioca's RBS rewriter currently calls
Spoom::Sorbet::Translate.rbs_comments_to_sorbet_sigsfor every file with a# typed:sigil. This adds a cheap prefilter so translation only runs when the source also contains#:or#|, the markers used by RBS comments.Why
The RBS rewriter runs while application files are being loaded. In large applications, many typed files do not contain RBS comments, so calling the translator for each of them is unnecessary work.
This keeps the existing behavior for files that can contain RBS comments while avoiding translation attempts for files that cannot produce RBS-derived runtime signatures.
Safety
This should be behavior-preserving:
# typed:and RBS comment markers still go through the existing translator.This does not change the broader Bootsnap/source-transform behavior; it only avoids unnecessary translator calls after source has been read.
Validation
Ran:
Both passed locally.
Follow-up
This is a conservative first step. A larger optimization would be to avoid disabling/bypassing Bootsnap for files that do not require RBS rewriting, while preserving byte-identical generated RBI output.