Skip to content

Delete redundant typecheck_prism Rake task #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amomchilov merged 1 commit into from
Aug 21, 2026
Merged

Delete redundant typecheck_prism Rake task #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ jobs:
rubygems: 4.0.4
- name: Run type check
run: bundle exec rake typecheck
- name: Run type check with Prism parser
run: bundle exec rake typecheck_prism
continue-on-error: true
- name: Run tests
run: bundle exec rake test
- name: Lint Ruby files
Expand Down
7 changes: 0 additions & 7 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@ desc "alias for typecheck"; task tc: :typecheck
desc "alias for typecheck"; task srb: :typecheck
desc "alias for typecheck"; task sorbet: :typecheck

desc "Type-check the code base with Sorbet using Prism"
task :typecheck_prism do
sh "bundle exec srb tc --parser=prism" do |ok, _res|
abort unless ok
end
end

require "minitest/test_task"

Minitest::TestTask.create do |t|
Expand Down
Loading