Remove optional ? in PT zip_regex#493
Open
AndreaSmith053122 wants to merge 2 commits into
Open
Conversation
AndreaSmith053122
requested review from
a team and
ananyaneogi
and removed request for
a team
Member
|
Might be good to add a changelog post ? Given that anyone consuming worldwide will start rejecting 4-digit PT zips now. |
ananyaneogi
reviewed
May 22, 2026
| tax_inclusive: true | ||
| group: European Countries | ||
| group_name: Europe | ||
| zip_regex: "^(PT?-?)?\\d{4}(-?\\d{3})?$" |
Member
There was a problem hiding this comment.
lets add a test for this regex behaviour change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Portugal postal code format should be XXXX-XXX, all numeric. Our current regex does not require the second set of three digits, despite it being the required format since 1998.
Contributes to https://github.com/shop/issues-checkout/issues/11587
What approach did you choose and why?
?part of the regex making the second set of digits optional.?that makes the-optional.What should reviewers focus on?
I don't think there's any way to flag these changes for a gradual rollout, but I'd be happy to hear otherwise.
The impact of these changes
[After services start using the new gem version]
Checklist