chore: remove dependency on tv4-formats#498
Closed
sarfata wants to merge 1 commit intoSignalK:masterfrom
Closed
Conversation
TV4-Format provides some JSON validation helper for common string formats. It was loaded only when validating the full model (not delta) and all the tests run without it so I propose we remove it. Reason for me looking into this is that this library causes problem with webpack because of a heuristic they use to require one of their dependency. This is a known issue that they have fixed in a later version and I have confirmed that upgrading the package fixes the issue for us too. However, if we do not use the library I think it's better to completely remove it. For more info: ikr/tv4-formats@61450dc
Contributor
Author
|
ping? @tkurki are you ok merging this? |
Member
|
all the tests run without it does not mean that it is not used: try mangling a timestamp in one of the test full files and run the tests - they will fail. This dependency adds validation of Options on how to move forward:
Then there is the issue of separating the schema js API #435 (including validation) from the actual schema data itself, versioning them separately. Then we would have the option two npm packages, one with schema data and js access to it and another for validation, versioned independently. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TV4-Format provides some JSON validation helper for common string
formats. It was loaded only when validating the full model (not delta)
and all the tests run without it so I propose we remove it.
Reason for me looking into this is that this library causes problem with
webpack because of a heuristic they use to require one of their
dependency. This is a known issue that they have fixed in a later
version and I have confirmed that upgrading the package fixes the issue
for us too. However, if we do not use the library I think it's better to
completely remove it.
For more info: ikr/tv4-formats@61450dc