Waypoint ID added to Course Definitions#660
Waypoint ID added to Course Definitions#660Techstyleuk wants to merge 2 commits intoSignalK:masterfrom
Conversation
Updating the specification to be inline with how its parsed in some of the nmea0183-signalk hooks. for example, APB. see: SignalK/nmea0183-signalk#239 This is a partial fix
this file was updated after running npm test
|
This should be aligned with the Course API where possible. |
|
I think between: Course API - the Spec. - nmea0183-signalk (APB) there are inconsistencies, APB writes the Waypoint as ......nextPoint.ID, but this is not in the spec. I added to the spec. If this shouldn't be in the spec. or if Course API should be updated to reflect the change, let me know what you are thinking? Having read the API, I am not sure what I would put to close that loop out |
|
I think that there are some paths written by plugins that addressed a specific need / use case at the time. For me, if the waypoint id is meaningful (has relevance) only to the device that transmitted it, I would question the need for a path in the spec. Some questions that probably need to be answered....
|
Updating the specification to be inline with how its parsed in some of the nmea0183-signalk hooks. for example, APB. see: SignalK/nmea0183-signalk#239
This is a partial fix