Skip to content

Paint the My list heading before the local list loads #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarthakagrawal927 merged 1 commit into from
Oct 11, 2026
Merged

Paint the My list heading before the local list loads #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions src/components/bucket-list/my-list-skeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,24 @@ export function MyListSkeleton() {
<div className="h-10 w-40 animate-pulse rounded bg-muted" />
<div className="mt-3 h-4 w-48 animate-pulse rounded bg-muted" />
<div className="mt-7 h-12 max-w-2xl animate-pulse rounded-xl bg-muted" />
<div className="mt-7 max-w-2xl divide-y divide-border">
{[1, 2, 3].map((row) => (
<div key={row} className="flex gap-4 py-5">
<div className="size-6 animate-pulse rounded-full bg-muted" />
<div className="flex-1 space-y-3">
<div className="h-5 w-3/4 animate-pulse rounded bg-muted" />
<div className="h-3 w-1/2 animate-pulse rounded bg-muted" />
</div>
<MyListRowsSkeleton className="mt-7 max-w-2xl" />
</div>
);
}

/** Row placeholders only, so the page heading and add field can paint first. */
export function MyListRowsSkeleton({ className = 'mt-7' }: { className?: string }) {
return (
<div aria-hidden="true" className={`divide-y divide-border ${className}`}>
{[1, 2, 3].map((row) => (
<div key={row} className="flex gap-4 py-5">
<div className="size-6 animate-pulse rounded-full bg-muted" />
<div className="flex-1 space-y-3">
<div className="h-5 w-3/4 animate-pulse rounded bg-muted" />
<div className="h-3 w-1/2 animate-pulse rounded bg-muted" />
</div>
))}
</div>
</div>
))}
</div>
);
}
15 changes: 11 additions & 4 deletions src/components/bucket-list/my-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useEffect, useRef, useState } from 'react';
import { StorageModeProvider, StorageModeStatus } from '~/components/storage-mode-provider';
import { normalizeDreamTitle } from '~/lib/dream-atlas';
import { ManualItemInput } from './manual-item-input';
import { MyListSkeleton } from './my-list-skeleton';
import { MyListRowsSkeleton } from './my-list-skeleton';
import {
localMyListStorage,
serverMyListStorage,
Expand Down Expand Up @@ -140,7 +140,6 @@ export function MyList({
/>
) : null;

if (!loaded && !error) return <MyListSkeleton />;
function row(item: MyListItem) {
return (
<div key={item.id}>
Expand Down Expand Up @@ -170,7 +169,9 @@ export function MyList({
My list
</h1>
<p className="mt-1 text-muted-foreground">
{active.length} still calling · {lived.length} lived
{loaded
? `${active.length} still calling · ${lived.length} lived`
: 'Opening your list…'}
</p>
</div>
<div className="max-w-32 pt-2 text-right">
Expand Down Expand Up @@ -208,7 +209,13 @@ export function MyList({
.
</p>
)}
<div className="mt-7 divide-y divide-border/60">{active.map(row)}</div>
{!loaded && !error ? (
<div role="status" aria-label="Loading My list">
<MyListRowsSkeleton />
</div>
) : (
<div className="mt-7 divide-y divide-border/60">{active.map(row)}</div>
)}
{lived.length > 0 && (
<details open className="mt-9">
<summary className="flex min-h-11 cursor-pointer list-none items-center justify-between border-t border-border/60 px-3 text-sm text-muted-foreground">
Expand Down
Loading