Repository navigation
Show honest loading and retry states across learning routes - #142
Merged
sarthakagrawal927 merged 4 commits intoOct 14, 2026
Merged
Conversation
…r footer Refs sass-maker/saas-maker#244, sass-maker/saas-maker#242 and sass-maker/saas-maker#241. Synthetic local acceptance only; production identity and device gates remain separate. Uses the published sass-maker/ui-library#12 compact API without replacing global CSS.
Refs sass-maker/saas-maker#244 and sass-maker/saas-maker#242. Retains the original Dashboard pending surface and healthy page geometry. Committed synthetic Slow4G/CPU4 browser checks cover pending, 503 and retry at 390/768/1440; production identity remains unqualified.
…ed progress Refs sass-maker/saas-maker#244 and #137. Retain mounted controls and local drafts through pending, error and retry states; preserve successful page geometry.
sarthakagrawal927
marked this pull request as ready for review
October 14, 2026 08:29
sarthakagrawal927
deleted the
agent/swe-loading-cloud-original-20261014
branch
October 16, 2026 19:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow or failed concept-mastery reads could look like completed empty learning state. This source change gives Learn, Today/Dashboard, Progress, and per-ID concept/roadmap/project routes an explicit pending, failure, and retry path. Retry keeps the current route/query and local project text. The existing learning design remains visible: roadmap graph, milestones, deep-dive links, and reading links stay accessible while account mastery is unavailable, without false zero-progress labels. The shared compact footer is used on interior routes; the landing footer is unchanged.
The branch contains the SHA-verified original frozen cloud commits (
adaba1b,03673fa), the separate per-ID successor cloud commit (ad4e8cc), and local design/test follow-up (5a58d68cb3446c6d860d3a96353642fab641938d). All source was imported into a managed worktree from currentmain; the cloud VM did not write GitHub or private state.Validation:
pnpm qualitypassed on Node 22 (the CI major), including format, lint, typecheck, 1,029 unit tests, complexity/duplication budgets, docs, build, and size. Focused Playwright passed 38/38 across 390, 768, and 1440 px in desktop and mobile projects; tests cover delayed, failed, empty, and recovered reads, route/query retention, same-route import retry, no horizontal overflow, and recovery CLS <= 0.05. Final error/settled screenshots were reviewed at phone and desktop widths. Exact-head CI passed.Remaining qualification in #141: real signed-in mastery behavior, cold placeholder <=300 ms, and live release verification. Refs #141 and sass-maker/saas-maker#244. The repo's Pages deployment workflow is
workflow_dispatchonly; production release remains a separate owner-approved action.