Skip to content

#23: Fix CCR_ThermostatSetpointCC_Rev03 - #59

Open
Aydogan Ersoz (silabs-aydogane) wants to merge 1 commit into
SiliconLabsSoftware:mainfrom
silabs-aydogane:GH-23-fix-thermostat-setpoint-type-mapping-and-get-after-set
Open

#23: Fix CCR_ThermostatSetpointCC_Rev03#59
Aydogan Ersoz (silabs-aydogane) wants to merge 1 commit into
SiliconLabsSoftware:mainfrom
silabs-aydogane:GH-23-fix-thermostat-setpoint-type-mapping-and-get-after-set

Conversation

@silabs-aydogane

Copy link
Copy Markdown
Collaborator

Issue

Closes: #23

Change

  • Fix V3 THERMOSTAT_SETPOINT_SUPPORTED_REPORT bitmask lookup
  • Queue THERMOSTAT_SETPOINT_GET after SET is assembled so SET→GET order is preserved (CL:0043.01.31.03.1)

Checklist

@cursor

cursor Bot commented Sep 3, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes Z-Wave thermostat interview and post-SET command sequencing; incorrect bitmask logic could skip or mis-order setpoint discovery, though scope is limited to this command class.

Overview
Fixes V3 thermostat setpoint interview by interpreting THERMOSTAT_SETPOINT_SUPPORTED_REPORT as a 1-indexed bitmask (bit N ⇒ setpoint type N; bit 0 unused). The old V3_BIT_TO_SETPOINT remap is removed; next_supported_setpoint_type now scans types 1–15 and tests the corresponding bit directly, so supported types match the spec during capabilities/GET chaining.

When a SET frame is assembled, the handler now creates a matching GET group for the same setpoint type and starts group resolution so a GET follows SET in order (per CC requirement CL:0043.01.31.03.1).

Reviewed by Cursor Bugbot for commit 625196f. Configure here.

@silabs-aydogane Aydogan Ersoz (silabs-aydogane) added On roadmap On the official roadmap and will be implemented by Silicon Labs Bug Issue is a bug report Silicon Labs development PR contents developed by Silicon Labs CTT Requested (Full Set) CTT Testing with full scope is requested from CTT Automation labels Sep 3, 2026
@silabs-aydogane
Aydogan Ersoz (silabs-aydogane) force-pushed the GH-23-fix-thermostat-setpoint-type-mapping-and-get-after-set branch from 625196f to 96767a6 Compare September 3, 2026 09:44
@siliconlabsdevops-svc-devops

Copy link
Copy Markdown

GitHub PR artifact is not available. Re-run CI, then apply the CTT label again.

@siliconlabsdevops-svc-devops siliconlabsdevops-svc-devops Bot removed the CTT Requested (Full Set) CTT Testing with full scope is requested from CTT Automation label Sep 3, 2026
@silabs-aydogane
Aydogan Ersoz (silabs-aydogane) force-pushed the GH-23-fix-thermostat-setpoint-type-mapping-and-get-after-set branch 2 times, most recently from 9d7b153 to 4e4a45c Compare September 3, 2026 12:39
@silabs-aydogane Aydogan Ersoz (silabs-aydogane) added the CTT Requested (Full Set) CTT Testing with full scope is requested from CTT Automation label Sep 3, 2026
@siliconlabsdevops-svc-devops siliconlabsdevops-svc-devops Bot removed the CTT Requested (Full Set) CTT Testing with full scope is requested from CTT Automation label Sep 3, 2026
@siliconlabsdevops-svc-devops

Copy link
Copy Markdown

CTT Jenkins job: $zpc_ctt_jenkins_url/job/zw-ctt-automation-multibranch/job/main/3624/

@silabs-aydogane
Aydogan Ersoz (silabs-aydogane) force-pushed the GH-23-fix-thermostat-setpoint-type-mapping-and-get-after-set branch from 4e4a45c to 5765885 Compare September 4, 2026 06:27
…ET after SET

Signed-off-by: Aydogan Ersoz <aydogan.ersoz@silabs.com>
@silabs-aydogane
Aydogan Ersoz (silabs-aydogane) force-pushed the GH-23-fix-thermostat-setpoint-type-mapping-and-get-after-set branch from 5765885 to d0466c1 Compare September 4, 2026 09:34
@silabs-aydogane Aydogan Ersoz (silabs-aydogane) changed the title #23: Fix V3 setpoint type bitmask lookup and add GET after SET #23: Fix CCR_ThermostatSetpointCC_Rev03 Sep 4, 2026
@silabs-aydogane Aydogan Ersoz (silabs-aydogane) added the CTT Requested (Full Set) CTT Testing with full scope is requested from CTT Automation label Sep 4, 2026
@siliconlabsdevops-svc-devops siliconlabsdevops-svc-devops Bot removed the CTT Requested (Full Set) CTT Testing with full scope is requested from CTT Automation label Sep 4, 2026
@siliconlabsdevops-svc-devops

Copy link
Copy Markdown

CTT Jenkins job: $zpc_ctt_jenkins_url/job/zw-ctt-automation-multibranch/job/main/3632/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Issue is a bug report On roadmap On the official roadmap and will be implemented by Silicon Labs Silicon Labs development PR contents developed by Silicon Labs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CCR_ThermostatSetpointCC_Rev03

2 participants