Skip to content

Use bitflags crate for ergonomics #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
The-Nice-One wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Use bitflags crate for ergonomics #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c04dcd1
Port core module to use bitflags crate
The-Nice-One May 7, 2026
115f7b7
Add .devcontainer/devcontainer.json file
The-Nice-One May 22, 2026
f5cbcbd
Add constant variables for flags
The-Nice-One May 22, 2026
a0835b0
Add bitflags fields to ABI structs
The-Nice-One May 22, 2026
dd14944
Fix ffi errors and warnings
The-Nice-One May 22, 2026
ec8f712
Refractor tests
The-Nice-One May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/rust
{
"name": "Rust",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/rust:1-1-bullseye",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

What are the available tags for mcr.microsoft.com/devcontainers/rust Docker images?

💡 Result:

Available tags for mcr.microsoft.com/devcontainers/rust (current variants and common tag patterns): 1) Latest - mcr.microsoft.com/devcontainers/rust:latest [1][2] - mcr.microsoft.com/devcontainers/rust:trixie [1][2] - mcr.microsoft.com/devcontainers/rust:bookworm [1][2] - mcr.microsoft.com/devcontainers/rust:bullseye [1][2] 2) Major version tags - mcr.microsoft.com/devcontainers/rust:1 (and OS-pinned variants mcr.microsoft.com/devcontainers/rust:1-trixie,:1-bookworm,:1-bullseye) [2] 3) “2” major and minor/patch semantic version tags (pattern includes OS-pinned variants) - Examples of tags shown in the upstream Rust devcontainer image docs: - mcr.microsoft.com/devcontainers/rust:2-1 (and:2-1-trixie,:2-1-bookworm,:2-1-bullseye) [2] - mcr.microsoft.com/devcontainers/rust:2.0-1 (and:2.0-1-trixie,:2.0-1-bookworm,:2.0-1-bullseye) [2] - mcr.microsoft.com/devcontainers/rust:2.0.9-1 (and:2.0.9-1-trixie,:2.0.9-1-bookworm,:2.0.9-1-bullseye) [2] Authoritative place to view the full, complete list - https://mcr.microsoft.com/en-us/artifact/mar/devcontainers/rust/tags [1] Note: The complete list of every published semantic-version tag is dynamic; the MCR “tags” page above is the authoritative source for all currently available tags. The variants listed (trixie/bookworm/bullseye) and tag naming patterns (latest/major/semantic-version-with-OS-suffix) are explicitly documented in the devcontainers image sources. [1][2]

Citations:

🏁 Script executed:

#!/bin/bash
# Check if the specified image tag exists in Microsoft Container Registry

IMAGE="mcr.microsoft.com/devcontainers/rust"
TAG="1-1-bullseye"

echo "Checking if ${IMAGE}:${TAG} exists..."
curl -s -o /dev/null -w "%{http_code}" "https://mcr.microsoft.com/v2/devcontainers/rust/manifests/${TAG}"
echo ""
echo "Response code 200 indicates the tag exists, 404 indicates it does not."

Repository: SimplePixelFont/spf.rs

Length of output: 213

Fix invalid devcontainer Rust image tag (1-1-bullseye)

  • .devcontainer/devcontainer.json (line 6) uses mcr.microsoft.com/devcontainers/rust:1-1-bullseye
  • MCR manifest lookup for 1-1-bullseye returns 404 (tag not available); published patterns use tags like 1-bullseye and 2-1-bullseye
  • Change the image tag to an existing variant (e.g., mcr.microsoft.com/devcontainers/rust:1-bullseye, or 2-1-bullseye if that’s the intended Rust version)
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.devcontainer/devcontainer.json at line 6, The devcontainer image tag
"mcr.microsoft.com/devcontainers/rust:1-1-bullseye" is invalid; update the
"image" value in .devcontainer/devcontainer.json (the "image" key) to a
published tag such as "mcr.microsoft.com/devcontainers/rust:1-bullseye" or
"mcr.microsoft.com/devcontainers/rust:2-1-bullseye" (choose the one matching the
intended Rust version) so the manifest resolves successfully.


// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
"settings": {},
"extensions": [
"streetsidesoftware.code-spell-checker"
]
}
},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "rustc --version",
"postCreateCommand": "sudo apt update && sudo apt install -y git-lfs && git lfs install"

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
5 changes: 5 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"cSpell.words": [
"PIXMAP"
]
}
98 changes: 54 additions & 44 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,15 @@ rustdoc-args = ["--cfg", "docsrs"]
default = ["std", "log", "serde", "ffi", "articles", "tagging"]
std = []
log = ["dep:log"]
serde = ["dep:serde"]
serde = ["dep:serde", "bitflags/serde"]
ffi = []
articles = []
tagging = []

[dependencies]
bitflags = { version = "2.11.1" }
log = { version = "0.4.27", optional = true }
serde = { version = "1.0.225", features = ["derive"], optional = true }
serde = { version = "1", features = ["derive"], optional = true }

[dev-dependencies]
env_logger = "0.11.8"
Loading
Loading