Skip to content

fix(ios): measure toast leading slots at their rendered width - #10

Merged
rehmatsg merged 2 commits into
mainfrom
codex/toast-avatar-layout
Sep 10, 2026
Merged

fix(ios): measure toast leading slots at their rendered width#10
rehmatsg merged 2 commits into
mainfrom
codex/toast-avatar-layout

Conversation

@rehmatsg

@rehmatsg rehmatsg commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix narrow iOS toasts that wrap their title and subtitle despite available space. Measurement now reserves the actual rendered leading-slot width (avatar, icon, or progress indicator), matching the live SwiftUI layout. Prepare patch release v0.8.1.

Changes

  • Share the actual leading-slot width between measurement and rendering.
  • Add native layout and leading-slot regression tests.
  • Update package version, changelog, and installation snippets for v0.8.1.

Testing

  • Native iOS simulator tests: 2 passed. The avatar layout regression failed before the fix (100pt constrained height versus 60pt natural height) and passes afterward.
  • App integration: Vance's complete suite passed with this fix pinned.
  • CI runs Dart analysis/tests, Swift compilation, iOS example build, and Android build/tests before merge.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes iOS toast measurement so titles and subtitles no longer wrap inside an undersized toast when there's enough screen space. The width probe now reserves the actual rendered leading-slot width (avatar, icon, or progress indicator) instead of a fixed icon-slot constant, matching the live SwiftUI layout.

  • Adds native regression tests covering avatar layout and leading-slot measurement.
  • Prepares the v0.8.1 patch release, updating package versions, changelog, and installation snippets.

Written for commit d49e647. Summary will update on new commits.

Review in cubic

@rehmatsg
rehmatsg merged commit 4897b4a into main Sep 10, 2026
5 checks passed
@rehmatsg
rehmatsg deleted the codex/toast-avatar-layout branch September 10, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant