Skip to content

Fixed local test eval#1376

Merged
SkBlaz merged 2 commits into
masterfrom
polish-polish
Jun 10, 2026
Merged

Fixed local test eval#1376
SkBlaz merged 2 commits into
masterfrom
polish-polish

Conversation

@SkBlaz

@SkBlaz SkBlaz commented Jun 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

@SkBlaz

SkBlaz commented Jun 9, 2026

Copy link
Copy Markdown
Owner Author

@copilot The fix is to update and commit the generated documentation outputs for this PR.

Why it failed:

  • The failing step is the workflow’s divergence check in .github/workflows/docs-examples.yml, lines 66–74.
  • That step runs:
    • git diff --exit-code examples/docs_outputs/
  • The log shows generation succeeded, but the repo became dirty afterward:
    • “Documentation outputs generated”
    • then “Documentation outputs have diverged!”
  • So the code itself did not crash; the checked-in files under examples/docs_outputs/ are out of date relative to the current example outputs.

Relevant source:

Solution:
Run the same generation step locally and commit the updated files:

python scripts/generate_docs_outputs.py
git add examples/docs_outputs/
git commit -m "Update generated documentation outputs"

If you want to reproduce CI more closely, use the workflow’s environment:

python -m venv .venv
source .venv/bin/activate
pip install numpy scipy
pip install -e .
MPLBACKEND=Agg python scripts/generate_docs_outputs.py

What likely changed:

  • scripts/generate_docs_outputs.py executes all examples in examples/getting_started/ and rewrites:
    • examples/docs_outputs/*.txt
    • examples/docs_outputs/*.err when present
    • examples/docs_outputs/manifest.json
  • Since the script already normalizes timestamps, memory addresses, and timing-related noise (see normalize_output() in the generator), this is most likely a legitimate output change from the PR rather than flaky formatting.

Code suggestion if this PR intentionally changed example behavior:

  • Include the regenerated snapshot files in the PR. That is the expected fix.

Code suggestion if this PR did not intend to change docs/example outputs:

  • Inspect which example output changed and either:
    1. restore the previous behavior in the example/library code, or
    2. accept the new behavior and commit the regenerated examples/docs_outputs/ files.

Most focused fix:

  • regenerate examples/docs_outputs/
  • commit the diff
  • push the updated snapshot files with the PR

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot The fix is to update and commit the generated documentation outputs for this PR.

Why it failed:
...

Regenerated examples/docs_outputs/ and committed the updated snapshot. The only change was in dsl_patterns_quick_reference.txt: the Apache Arrow output line changed from OK Apache Arrow table: 18 rows x 2 columns to OK Apache Arrow: (skipped - pyarrow not installed), reflecting the absence of pyarrow in the CI environment. Committed in Update generated documentation outputs.

Copilot finished work on behalf of SkBlaz June 9, 2026 07:39
@SkBlaz SkBlaz merged commit a30bd52 into master Jun 10, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants