Repository navigation
Choose the game platform and clean completed download staging - #1
Merged
Merged
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Installing a game could silently follow an old compatibility preference instead of letting the user choose its platform. The install sheet now offers the supported macOS and Windows versions, preselects macOS when available, and requires explicit confirmation. The selected version is recorded in the download queue and installation metadata; pause, retry, restart and updates retain it. Launch and game settings use the version actually installed. Existing installations still require removal before changing platform.
Completed installations could also leave obsolete
.skinos-APPID-BUILD.partialdirectories behind. Cleanup now runs after a persisted successful installation and on startup for completed queue entries. It removes only older staging builds after verifying installation metadata and acquiring operation locks. Any unfinished, paused, cancelled or failed intent for that game in another account prevents cleanup; symlink targets, current/newer builds and installed game files are preserved.Validation
Review fixes
Cache cleanup now runs as supervised background work with AppID/destination reservations. Unrelated downloads, progress and pause/cancel commands remain responsive during large cleanups. Regression coverage includes a stalled cleanup, destination protection, correlated manual responses and shutdown draining.
Review notes
Queue and installation platform fields are optional for legacy data and resolved from existing metadata/files. Cleanup failures are reported separately and cannot turn a successful installation into a failed download. No credential storage, runtime permissions or external dependencies are changed. Version is 0.1.4, build 5.
UI verification contains account/library data, so no unredacted screenshot is attached.