Repository navigation
Conversation
The source files each claimed to be confidential and proprietary, which is not what this is meant to be. - Added the MIT licence text as LICENSE. - Replaced the proprietary notice in all 41 source and documentation files with the copyright line and a pointer to the licence, keeping attribution. - Updated the header template in the coding guidelines so files written from now on carry the same notice. - Updated the copyright recorded in both assemblies, which is what shows in the file properties of the built binaries. - Reworked the licence section of the README. TruRNGpro/rng.h is left alone. It is third-party and its author states in the file that it carries no copyright and no warranty, so it is not this project's to relicense. The README says so, correcting what it previously said about the licensing being unestablished. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0153VVkWg7DQmdaNLcvtY37w
There was a problem hiding this comment.
🟡 Changes recommended
Two updated files have incorrect File Name: values in their standardized header blocks, which should be corrected for consistency and accuracy.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repository’s licensing posture to MIT by adding a root LICENSE file, replacing proprietary/confidential notices in file headers with an MIT pointer, and aligning README + assembly metadata so built artifacts and documentation reflect the new license.
Changes:
- Added MIT license text in
LICENSEand updated README license section accordingly. - Replaced proprietary/confidential header notices across source/docs/tests with a short MIT license pointer.
- Updated
AssemblyCopyrightattributes to reflect2022-2026and MIT licensing.
File summaries
| File | Description |
|---|---|
| XMLDataPoint.cs | Replaced proprietary header notice with MIT license pointer. |
| XMLConstants.cs | Replaced proprietary header notice with MIT license pointer. |
| TruRNGpro/TruRNGproMain.cpp | Replaced proprietary header notice with MIT license pointer (header “File Name” currently mismatched). |
| TruRNGpro/TruRNGpro.h | Replaced proprietary header notice with MIT license pointer. |
| TruRNGpro/RNGSimulator.h | Replaced proprietary header notice with MIT license pointer. |
| TruRNGpro/RNGInterface.h | Replaced proprietary header notice with MIT license pointer. |
| TruRNGpro/pch.h | Replaced proprietary header notice with MIT license pointer. |
| TruRNGpro/pch.cpp | Replaced proprietary header notice with MIT license pointer. |
| TruRNGpro/framework.h | Replaced proprietary header notice with MIT license pointer. |
| TruRNGpro/CODING_GUIDELINES_CPP.md | Updated C++ header template to use MIT license pointer. |
| TargetValues.cs | Replaced proprietary header notice with MIT license pointer. |
| StatisticalAnalysis.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGXMLWriter.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGXMLReader.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGSessionTimer.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGSessionDataFile.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGSessionData.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGDeviceTimer.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGDevice.cs | Replaced proprietary header notice with MIT license pointer. |
| RNGChart.cs | Replaced proprietary header notice with MIT license pointer. |
| README.md | Reworked third-party/license wording and updated license section to MIT. |
| RandomNumberGenerator.Test/XMLDataPoint.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/TargetValues.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/StatisticalAnalysis.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/RNGXMLWriter.Test.cs | Replaced proprietary header notice with MIT license pointer (header “File Name” currently mismatched). |
| RandomNumberGenerator.Test/RNGXMLReader.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/RNGSessionTimer.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/RNGSessionDataFile.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/RNGSessionData.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/RNGDeviceTimer.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/RNGDevice.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/RNGChart.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/Properties/AssemblyInfo.cs | Updated assembly copyright string for MIT + 2022–2026. |
| RandomNumberGenerator.Test/HistogramChart.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/GeneratorForm.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/DeviceUpdateThread.Test.cs | Replaced proprietary header notice with MIT license pointer. |
| RandomNumberGenerator.Test/CODING_GUIDELINES_TESTS.md | Updated test header template to use MIT license pointer. |
| Properties/AssemblyInfo.cs | Updated assembly copyright string for MIT + 2022–2026. |
| Program.cs | Replaced proprietary header notice with MIT license pointer. |
| LICENSE | Added MIT license text for the repository. |
| HistogramChart.cs | Replaced proprietary header notice with MIT license pointer. |
| GeneratorForm.Designer.cs | Replaced proprietary header notice with MIT license pointer. |
| GeneratorForm.cs | Replaced proprietary header notice with MIT license pointer. |
| DeviceUpdateThread.cs | Replaced proprietary header notice with MIT license pointer. |
| CODING_GUIDELINES.md | Updated C# header template to use MIT license pointer. |
Review details
Files not reviewed (1)
- GeneratorForm.Designer.cs: Generated file
- Files reviewed: 44/45 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RNGXMLWriter.Test.cs named RNGSessionDataFile.Test.cs and TruRNGproMain.cpp named dllmain.cpp, both left over from the files they were copied or renamed from. Every header in the repository was checked against the name of the file holding it, and these were the only two that disagreed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0153VVkWg7DQmdaNLcvtY37w
There was a problem hiding this comment.
🔵 Needs a closer look
The README’s wording asserts a “public domain” status for rng.h that may be stronger than the informal disclaimer it describes and should be rephrased for accuracy.
Review details
Files not reviewed (1)
- GeneratorForm.Designer.cs: Generated file
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
README.md:150
- The README states
TruRNGpro/rng.his treated as being in the public domain. Given the file reportedly contains an informal statement (not a formal dedication like CC0), calling it "public domain" is stronger than what the README later qualifies and can be misleading; consider rephrasing to describe it as author-disclaimed/not under this project's MIT license without asserting a specific legal status.
- Files reviewed: 44/45 changed files
- Comments generated: 0 new
- Review effort level: Lite
The README said rng.h is treated as being in the public domain. Its author disclaimed copyright informally rather than making a formal dedication such as CC0, and reading a legal status into that is more than the wording supports. It now quotes what the file says, states the one thing that is certain, that the header is not covered by this project's licence, and leaves settling it with the author to whoever needs the licensing stated precisely. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0153VVkWg7DQmdaNLcvtY37w
There was a problem hiding this comment.
🟢 Approval recommended
Changes are limited to licensing/documentation/header metadata updates and were verified to remove the prior proprietary notice consistently.
Review details
Files not reviewed (1)
- GeneratorForm.Designer.cs: Generated file
- Files reviewed: 44/45 changed files
- Comments generated: 0 new
- Review effort level: Lite
Copilot stopped reviewing on behalf of
Skorinn due to an error
September 4, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source files each claimed to be confidential and proprietary, which is not what this is meant to be.
What changed
LICENSE, copyright 2022-2026 Mike Pullen.AssemblyCopyrightin both assemblies. This is what shows in the file properties of the built binaries, which now readCopyright (c) 2022-2026 Mike Pullen. MIT License.The third-party header
TruRNGpro/rng.his left exactly as it is. It is not this project's to relicense, and its author states in the file:The README previously said the licensing of this file had not been established. That was wrong and is corrected here: the author disclaimed copyright, so no particular legal status is claimed for it. It is simply not covered by this project's licence. It is worth noting that this is an informal statement rather than a formal dedication such as CC0, which matters only if the licensing of the whole ever has to be stated precisely.
Verification
git diffconfirmsrng.his byte-identical; it does not appear in this change at all.🤖 Generated with Claude Code
https://claude.ai/code/session_0153VVkWg7DQmdaNLcvtY37w