Skip to content

Support installation (rebased)#61

Open
jcfr wants to merge 5 commits into
Slicer:masterfrom
jcfr:44-support-installation
Open

Support installation (rebased)#61
jcfr wants to merge 5 commits into
Slicer:masterfrom
jcfr:44-support-installation

Conversation

@jcfr

@jcfr jcfr commented Apr 12, 2016

Copy link
Copy Markdown
Member

Work in progress.

jcfr and others added 5 commits March 21, 2018 18:40
@jcfr
STYLE: GenerateCLP.cmake should only be copied. See Slicer#44
291e251
@jcfr
ENH: Fix GenerateCLP install rules. See Slicer#44
429e9a8 
* Introduce GenerateCLP_INSTALL_CMAKE_DIR variable allowing to
configure install location for "GenerateCLP.cmake" macro.

* GenerateCLP_INSTALL_NO_DEVELOPMENT: Change default value from ON to
OFF. This will ensure GenerateCLP macro and dependent files are installed
by default.

* GenerateCLPLauncher:

 - Update hardcoded location of ITK libraries. It was changed from "bin"
 to "lib" in ITKv4.

 - Update forward install dir to account for that fact both GenerateCLP
 and launcher are installed in the same directory.

* Ensure following files are installed:
 - UseGenerateCLP.cmake
 - GenerateCLPConfig.cmake
 - GenerateCLP.cmake

Co-authored-by: Nicole Aucoin <nicole@bwh.harvard.edu>
@jcfr
ENH: Add infrastructure to test GenerateCLP install rules. See Slicer#44
a55a41c 


* Introduced "GenerateCLP-Install.cmake" script that is deleting
the directory associated with CMAKE_INSTALL_PREFIX, and re-installing
the files building the "install" target.

* Introduced variable TEST_TREETYPE set to either "BuildTree"
or "InstallTree". This variable allows to conditionally update the
testing context in Configure, Build or Test steps associated with
each examples.

* For the "BuildTree" case, GenerateCLP_DIR is hardcoded in
GenerateCLPTestPrerequisites whereas it is passed as test argument
for the "InstallTree" case.

Co-authored-by: Nicole Aucoin <nicole@bwh.harvard.edu>
@jcfr
ENH: Update GenerateCLP tests to build/install its own GenerateCLP. See
21714b9 
Slicer#44

This will ensure running the tests will not delete files associated
with the current CMAKE_INSTALL_PREFIX.

Co-authored-by: Nicole Aucoin <nicole@bwh.harvard.edu>
@jcfr
WIP
8d82e1a
@jcfr jcfr force-pushed the 44-support-installation branch from 235305b to 8d82e1a Compare March 21, 2018 23:05
@jcfr jcfr changed the title Support installation Support installation (rebased) Mar 21, 2018
@jcfr

jcfr commented Mar 21, 2018

Copy link
Copy Markdown
Member Author 
The following tests FAILED:
	  5 - GenerateCLP-Install (Failed)
	  7 - GenerateCLPTest-InstallTree-Slicer3Example-Configure (Failed)
	  9 - GenerateCLPTest-InstallTree-Slicer3Example-Build (Failed)
	 13 - GenerateCLPTest-InstallTree-PointExample1-Configure (Failed)
	 15 - GenerateCLPTest-InstallTree-PointExample1-Build (Failed)
	 17 - GenerateCLPTest-InstallTree-CLPExample1-Configure (Failed)
	 19 - GenerateCLPTest-InstallTree-CLPExample1-Build (Failed)
	 23 - GenerateCLPTest-InstallTree-CLPTestMultiple-Configure (Failed)
	 25 - GenerateCLPTest-InstallTree-CLPTestMultiple-Build (Failed)

@jcfr jcfr added the wip label Mar 21, 2018
@jcfr jcfr mentioned this pull request Dec 14, 2018
Open
@hjmjohnson

hjmjohnson commented Apr 20, 2019

Copy link
Copy Markdown
Member

@jcfr Confirmed that tests still fail even after rebasing on master branch:

The following tests FAILED:
5 - GenerateCLP-Install (Failed)
7 - GenerateCLPTest-InstallTree-Slicer3Example-Configure (Failed)
9 - GenerateCLPTest-InstallTree-Slicer3Example-Build (Failed)
13 - GenerateCLPTest-InstallTree-PointExample1-Configure (Failed)
15 - GenerateCLPTest-InstallTree-PointExample1-Build (Failed)
17 - GenerateCLPTest-InstallTree-CLPExample1-Configure (Failed)
19 - GenerateCLPTest-InstallTree-CLPExample1-Build (Failed)
23 - GenerateCLPTest-InstallTree-CLPTestMultiple-Configure (Failed)
25 - GenerateCLPTest-InstallTree-CLPTestMultiple-Build (Failed)

@jcfr

jcfr commented Jan 23, 2020

Copy link
Copy Markdown
Member Author

@RafaelPalomar

@hjmjohnson

hjmjohnson commented Aug 8, 2023

Copy link
Copy Markdown
Member

@jcfr. 7 years since this opened, 3.5 years since comments were made. Is this still relevant?

@ferdymercury

ferdymercury commented Jun 25, 2026

Copy link
Copy Markdown

Is this still relevant?

I'd argue the goal is still relevant, to have the option of installing this library so that it can be packaged / reused by others, ie not depending on the build tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

wip

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcfr @hjmjohnson @ferdymercury