Open
Conversation
Test Results 71 files 485 suites 0s ⏱️ Results for commit d3ae5af. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d3ae5af |
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
5abb504 to
eb50abd
Compare
|
Invitation URL: |
hcarter-775
reviewed
Feb 5, 2026
...atter-sensor/src/embedded_clusters/SoilMeasurement/server/attributes/AcceptedCommandList.lua
Outdated
Show resolved
Hide resolved
...ings/matter-sensor/src/embedded_clusters/SoilMeasurement/server/attributes/AttributeList.lua
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,67 @@ | |||
| local cluster_base = require "st.matter.cluster_base" | |||
Contributor
There was a problem hiding this comment.
and this one, unless you're planning on adding a handler for this?
Contributor
Author
There was a problem hiding this comment.
Yep, I'll remove it
hcarter-775
reviewed
Feb 5, 2026
| if #battery_feature_eps > 0 then | ||
| device:send(clusters.PowerSource.attributes.AttributeList:read()) | ||
| else | ||
| device_cfg.match_profile(driver, device, fields.battery_support.NO_BATTERY) |
Contributor
There was a problem hiding this comment.
I think we need to add some kind of handling to the match_profile function so that it can support battery? Along with a couple unit tests?
Contributor
Author
There was a problem hiding this comment.
That should already be supported, no?
Contributor
There was a problem hiding this comment.
how would it be?
edit: nevermind, I forgot how the Matter Sensor match profile logic works.
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
2761208 to
a7fcbb4
Compare
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
a7fcbb4 to
09c0f55
Compare
nickolas-deboom
commented
Feb 5, 2026
| clusters.RadonConcentrationMeasurement.attributes.MeasuredValue, | ||
| clusters.RadonConcentrationMeasurement.attributes.MeasurementUnit, | ||
| }, | ||
| [capabilities.relativeHumidityMeasurement.ID] = { |
Contributor
Author
There was a problem hiding this comment.
This was a duplicate entry
nickolas-deboom
commented
Feb 5, 2026
| -- remove leading "-" | ||
| profile_name = string.sub(profile_name, 2) | ||
|
|
||
| device.log.info_with({hub_logs=true}, string.format("Updating device profile to %s.", profile_name)) |
Contributor
Author
There was a problem hiding this comment.
I removed this log because I realized this is now logged by the lua libs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the Soil Sensor device type, introduced with Matter 1.5.