chore: disable minification of dist bundles - #11
Closed
John-David Dalton (jdalton) wants to merge 1 commit into
Closed
chore: disable minification of dist bundles#11John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
John-David Dalton (jdalton)
marked this pull request as ready for review
April 13, 2026 19:50
- Removes the terser minification plugin from the rollup config - The dist bundles are now readable and easier to review in PRs
John-David Dalton (jdalton)
force-pushed
the
chore/disable-minification
branch
from
July 24, 2026 22:01
c27b412 to
b9d37e9
Compare
Collaborator
Author
|
Superseded, with one line kept. The minification half is already done on main and better enforced than this branch proposed: #14 replaced the rollup build with rolldown, whose config sets The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files that actually run in every consumer's CI job are
dist/main.jsanddist/post.js— the bundled output, notsrc/. Until now they were minified, which meant the one artifact people most want to audit before trusting a security action was the one artifact nobody could read.Dropping the
terserplugin from the rollup config makes the bundles readable, so you can see exactly what a release contains just by opening the file.The dist files get larger as a result. That is fine here: GitHub Actions downloads them once per job and they are never served to a browser, so bundle size buys nothing that readability does not beat.
Keeping the PR diffs usable —
.gitattributesmarksdist/as generatedUnminified bundles would otherwise turn every build commit into a huge, noisy diff. A new
.gitattributessetsdist/** -diff linguist-generated, so GitHub collapses the generated output by default and excludes it from language stats. The files stay fully readable when you open them — they just stop drowning the review.Removing the plugin also drops
@rollup/plugin-terserand its@jridgewell/*source-map dependencies from the lockfile.The test plan — unchecked; two things to confirm before merge
npm run buildstill produces workingdist/main.jsanddist/post.js