Skip to content

Commit 53502d0

Browse files
committed
Reduce the summary line to just the generated count
Drop failed/skipped/empty from the tally: a failure aborts the whole walk immediately rather than accumulating (and is already reported via its own fail message), and the disabled/covered/empty buckets count candidate directories rather than independent build roots, so a total there is just as misleading as the "N build root(s)" figure already removed.
1 parent 4a41695 commit 53502d0

1 file changed

Lines changed: 6 additions & 13 deletions

File tree

src/commands/manifest/output-manifest-dynamic-sbom-inference.mts

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,14 @@ function renderTable(outcomes: readonly RecursiveManifestOutcome[]): string {
1919
.join('\n')
2020
}
2121

22+
// Only the generated count is reported: a failure aborts the whole walk
23+
// immediately (already reported via its own fail message) rather than
24+
// accumulating alongside successes, and the disabled/covered/empty buckets
25+
// count candidate directories, not independent build roots, so a total
26+
// there would be just as misleading as the removed "N build root(s)" one.
2227
function summarize(outcomes: readonly RecursiveManifestOutcome[]): string {
2328
const generated = outcomes.filter(o => o.status === 'generated').length
24-
const failed = outcomes.filter(o => o.status === 'failed').length
25-
const skippedCovered = outcomes.filter(
26-
o => o.status === 'skippedCovered',
27-
).length
28-
const skippedDisabled = outcomes.filter(
29-
o => o.status === 'skippedDisabled',
30-
).length
31-
const empty = outcomes.filter(o => o.status === 'empty').length
32-
return (
33-
`Generated ${generated} Socket facts file(s); ` +
34-
`${failed} failed, ${skippedCovered} skipped (already covered), ` +
35-
`${skippedDisabled} skipped (disabled/pom), ${empty} empty.`
36-
)
29+
return `Generated ${generated} Socket facts file(s).`
3730
}
3831

3932
export async function outputManifestDynamicSbomInference(

0 commit comments

Comments
 (0)