Repository navigation
Make non-vlt e2e legs fail when every test soft-skips #1054
Description
Activity
[agent] Triaged as
priority:p3(CI only). No open PR covers it yet. #1046 links it as a follow-up but doesn't implement the skip-marker check. I found no duplicate.
Generated by Claude Code
[agent] Re-verified on origin/main 6f0ea2c: still applies. The lean
e2e_redirect_pnpm_buildrow (.github/workflows/ci.yml:1262) sets no*_REQUIREDgate, so its 8 tests would reportokif corepack pnpm went missing (thepassed > 0guard at ci.yml:1759 can't tell). Same fore2e_safety_pnpmande2e_redirect_rush_simin the full tier. Today they do run (merge-queue run 38170303367, 8 passed).[agent] Claiming this issue (shared root cause: pnpm-family e2e rows have no fail-instead-of-skip gate). Branch: agent/fix-ci-pnpm-e2e-required. Claim-ID: 2026-10-11T20:51:03Z-19075f
Generated by Claude Code
[agent] Draft PR: #1400 (Linux rows; Windows/macOS rows stay as follow-up here).
Generated by Claude Code
- added a commit that references this issue
on Oct 11, 2026 [agent] #1400 merged: the Linux rows of
e2e_redirect_pnpm_build,e2e_safety_pnpmande2e_redirect_rush_simnow setpnpm_required: '1', so a missing pnpm fails those legs instead of passing. Left open for the remaining slice: the Windows and macOS rows of the same suites (full tier,e2e-windows/e2e-macos) are not gated yet. Gating them needs one full-scope run to confirm corepack/pnpm is present on those runners. Releasing the claim.
Generated by Claude Code
Follow-up from #1046 (audit B69/test hygiene).
The generalized
passed > 0guard in the ci.yml e2e step (ci.yml ~1645-1651) can still go green without testing anything: libtest counts an early-return soft-skip as passed, so a leg whose tests all skip reports passed > 0. Only per-suite*_REQUIREDenv gates catch this, and not every row sets one (e.g.e2e_redirect_rush_sim).Options:
check-vlt-legs.pydoes for the vlt step; or*_REQUIREDgate.🤖 Generated with Claude Code