[agent] Filed by the scheduled architecture audit routine (CLI and core). Register: discussion #560 register.
Kind: tracking. Source: review 6.4, 7.3; register C20.
Problem (verified on 045d7ec)
utils/purl.rs has two builder families:
On top of these, 42 production format!("pkg:…") sites outside utils/purl.rs build purls by hand. The review counted 48; corrected here. The largest groups:
vex/product.rs: 13 sites, including versionless purlsvendor/path.rs::leaf_to_purl: 10vendor/lock_inventory/recover.rs: 6vex/discover/mod.rs: 5, with their own PyPI/composer/nuget canonicalization in discover/mod.rs L1455-L1468hosted/engine.rs:622
There are also 24 inline starts_with("pkg:<type>/") checks beside Ecosystem::from_purl.
Drift already present. The families disagree on canonicalization:
composer_purl lowercases, while build_composer_purl, leaf_to_purl and recover.rs don't.pypi_purl canonicalizes the name, while leaf_to_purl, recover.rs and the hosted skip purl (hosted/engine.rs:622) don't. vex::discover re-canonicalizes afterwards.vlt.rs:290 alone percent-encodes the npm scope @.
Every consumer that compares purls therefore needs purl_eq/normalize_purl to paper over the differences.
Target design
utils::purl exposes one validated constructor per ecosystem (or Purl::new(Ecosystem, ns, name, version) -> Option<String>) that owns name canonicalization (PyPI PEP 503, composer and nuget lowercase), plus one versionless base_purl. build_* becomes private or is deleted.- Type checks go through
Ecosystem::from_purl.
Checklist (one PR each, in order)
Dependencies
Consolidated work — backlog review, 2026-10-08
The following standalone issues are now tracked here. Their closure consolidates scheduling; it does not mean their implementation is complete. Original reports and discussion remain linked below.
#630: Move the crawler coordinate guards and composer's leading-v rule into utils and delete the copies
Preserved scope and acceptance criteria from #630
Proposed change
- Add
path_safety::is_safe_name_version(name, version) and move is_safe_maven_coordinate into utils::path_safety.
- Call them from the three crawlers,
simple_purl, maven_purl and vendor/maven_repo.rs.
- Make
utils::composer_version::strip_leading_v pub(crate) and point every normalize_version caller at it: the composer crawler and its oracle, formats::composer, lock_inventory::composer and upstream::composer.
Delete: is_safe_{cargo,gem,nuget}_coordinate and their three test copies (keep one table test on the shared function), plus composer_crawler::normalize_version.
Size and scope
About 40 production lines deleted and about 10 added, in crawlers/{cargo,ruby,nuget,maven,composer}_crawler.rs, utils/{path_safety,purl,composer_version}.rs, formats/composer/mod.rs, patch/redirect/upstream/composer.rs and vendor/maven_repo.rs. There is no behavior change. Out of scope: the go and deno guards, which use multi-segment and JSR-component rules, and the purl builder families (C20).
Acceptance criteria
[agent] Filed by the scheduled architecture audit routine (CLI and core). Register: discussion #560 register.
Kind: tracking. Source: review 6.4, 7.3; register C20.
Problem (verified on
045d7ec)utils/purl.rshas two builder families:build_gem_purl…build_cargo_purl. There are 7 of them, plainformat!, with 21 production callers.npm_purl…maven_purl. They returnNonefor unsafe coordinates; lockfile discovery and the lock inventory use them.On top of these, 42 production
format!("pkg:…")sites outsideutils/purl.rsbuild purls by hand. The review counted 48; corrected here. The largest groups:vex/product.rs: 13 sites, including versionless purlsvendor/path.rs::leaf_to_purl: 10vendor/lock_inventory/recover.rs: 6vex/discover/mod.rs: 5, with their own PyPI/composer/nuget canonicalization in discover/mod.rs L1455-L1468hosted/engine.rs:622There are also 24 inline
starts_with("pkg:<type>/")checks besideEcosystem::from_purl.Drift already present. The families disagree on canonicalization:
composer_purllowercases, whilebuild_composer_purl,leaf_to_purlandrecover.rsdon't.pypi_purlcanonicalizes the name, whileleaf_to_purl,recover.rsand the hosted skip purl (hosted/engine.rs:622) don't.vex::discoverre-canonicalizes afterwards.vlt.rs:290alone percent-encodes the npm scope@.Every consumer that compares purls therefore needs
purl_eq/normalize_purlto paper over the differences.Target design
utils::purlexposes one validated constructor per ecosystem (orPurl::new(Ecosystem, ns, name, version) -> Option<String>) that owns name canonicalization (PyPI PEP 503, composer and nuget lowercase), plus one versionlessbase_purl.build_*becomes private or is deleted.Ecosystem::from_purl.Checklist (one PR each, in order)
Ecosystem::from_purl(mechanical; can start now).vendor/{gem,maven_repo,nuget_feed,composer_lock}.rs) andredirect/golang_local.rsmove to the validated builders. An unsafe coordinate becomes a refusal instead of a ledger key. Owner: ecosystems area.vendor/path.rs::leaf_to_purlandlock_inventory/recover.rsbuild through the validated builders, canonicalizing PyPI and composer once. Delete the re-canonicalization invex::discover.vex/product.rsversionless/product purls through onebase_purlbuilder.build_*family andpurl_name_version, which only has a test caller.Dependencies
audit-ecosystems), so coordinate with E-rows onvendor/andvex/.formats).Consolidated work — backlog review, 2026-10-08
The following standalone issues are now tracked here. Their closure consolidates scheduling; it does not mean their implementation is complete. Original reports and discussion remain linked below.
#630: Move the crawler coordinate guards and composer's leading-v rule into utils and delete the copies
Preserved scope and acceptance criteria from #630
Proposed change
path_safety::is_safe_name_version(name, version)and moveis_safe_maven_coordinateintoutils::path_safety.simple_purl,maven_purlandvendor/maven_repo.rs.utils::composer_version::strip_leading_vpub(crate)and point everynormalize_versioncaller at it: the composer crawler and its oracle,formats::composer,lock_inventory::composerandupstream::composer.Delete:
is_safe_{cargo,gem,nuget}_coordinateand their three test copies (keep one table test on the shared function), pluscomposer_crawler::normalize_version.Size and scope
About 40 production lines deleted and about 10 added, in
crawlers/{cargo,ruby,nuget,maven,composer}_crawler.rs,utils/{path_safety,purl,composer_version}.rs,formats/composer/mod.rs,patch/redirect/upstream/composer.rsandvendor/maven_repo.rs. There is no behavior change. Out of scope: the go and deno guards, which use multi-segment and JSR-component rules, and the purl builder families (C20).Acceptance criteria
utils::path_safety.formats/,utils/andpatch/redirect/no longer importcrawlers::composer_crawler::normalize_versionorcrawlers::maven_crawler::is_safe_maven_coordinate.purl_builders_validate_coordinatesand the composertest_normalize_versioncases, moved tostrip_leading_v, stay green.cargo test -p socket-patch-core --lib crawlersandcargo clippy --workspace --all-features -- -D warningsstay green.