Decide whether a hosted patch is pinned through lockfile discovery alone

crates/socket-patch-cli/src/commands/context.rs

@@ -18,7 +18,7 @@ use std::path::PathBuf;
 
 use socket_patch_core::ledgers::{Ledgers, LoadedLedgers};
 use socket_patch_core::vendor::lock_inventory::{
-    DiskSnapshot, LockfileEntry, ProjectView, UnsupportedNpmLayout,
+    DiskSnapshot, LockfileEntry, ProjectView, ReadSet, UnsupportedNpmLayout,
 };
 use socket_patch_core::vex::discover::Discovery;
 use tokio::sync::OnceCell;
@@ -39,7 +39,10 @@ pub(crate) struct ProjectContext<'a> {
     snapshot: DiskSnapshot<'a>,
     ledgers: OnceCell<LoadedLedgers>,
     locks: OnceCell<LockSet>,
-    discovery: OnceCell<Discovery>,
+    /// The discovery, with the paths it read and their fingerprints
+    /// (`None` when they cannot cover what it read; see
+    /// [`DiskSnapshot::end_recording`]).
+    discovery: OnceCell<(Discovery, Option<ReadSet>)>,
 }
 
 impl<'a> ProjectContext<'a> {
@@ -53,7 +56,7 @@ impl<'a> ProjectContext<'a> {
         Self {
             common,
             root,
-            snapshot: DiskSnapshot::new(&common.cwd),
+            snapshot: DiskSnapshot::tracked(&common.cwd),
             ledgers: OnceCell::new(),
             locks: OnceCell::new(),
             discovery: OnceCell::new(),
@@ -93,8 +96,18 @@ impl<'a> ProjectContext<'a> {
 
     /// The lockfile wiring discovery of `--cwd` ([`super::discover_wiring`]).
     pub(crate) async fn discovery(&self) -> &Discovery {
+        &self.recorded_discovery().await.0
+    }
+
+    /// [`Self::discovery`] with the read set that tells whether it still
+    /// describes the project (stats only; see [`ReadSet::unchanged`]).
+    pub(crate) async fn recorded_discovery(&self) -> &(Discovery, Option<ReadSet>) {
         self.discovery
-            .get_or_init(|| super::discover_wiring_in(self.common, &self.snapshot))
+            .get_or_init(|| async {
+                self.snapshot.begin_recording();
+                let discovery = super::discover_wiring_in(self.common, &self.snapshot).await;
+                (discovery, self.snapshot.end_recording())
+            })
             .await
     }
 }

crates/socket-patch-cli/src/commands/mod.rs

@@ -106,12 +106,7 @@ pub(crate) async fn discover_wiring_in(
 
 fn discover_options(common: &crate::args::GlobalArgs) -> socket_patch_core::vex::DiscoverOptions {
     socket_patch_core::vex::DiscoverOptions {
-        patch_server_origins: common
-            .patch_server_url
-            .iter()
-            .filter(|url| !url.trim().is_empty())
-            .cloned()
-            .collect(),
+        patch_server_origins: rollback::patch_server_origins(common),
     }
 }
 
@@ -137,6 +132,7 @@ pub(crate) async fn hosted_inventory(
 /// edits) — it is never persisted.
 ///
 /// [`RedirectState`]: socket_patch_core::patch::redirect::RedirectState
+#[cfg(test)]
 pub(crate) async fn hosted_state_from_lockfiles(
     common: &crate::args::GlobalArgs,
     root: &Path,