Consolidated terminal UI and CLI-wide output polish

[Mikola Lysenko (mikolalysenko)]

Summary

scan's progress lines garbled on a real terminal. Warnings also printed in the middle of an active progress line.

Found 7 patches for 1 packagesatch 7/7)

An end-to-end audit ran every command under a pty, through pipes, and with --json, --silent and NO_COLOR. It found 243 verified issues of the same kind across the CLI. This PR fixes them. It also moves all terminal-UI logic into one small, unit-tested module.

New crates/socket-patch-cli/src/ui/

This module replaces output.rs and drops the unused indicatif dependency.

• StatusLine<W: Write>: a hand-rolled, deterministic status line. There is no ticker thread, so the output bytes are exact and testable.
  • Every update writes \r\x1b[2K plus the message, truncated to the terminal width.
  • println puts a line above an active status line.
  • The line is cleared on finish and on Drop.
  • It is never drawn off a TTY, under TERM=dumb, in debug mode, or under --json/--silent.
• Prompts (confirm, confirm_or_proceed, select_one), built on a testable confirm_with core:
  • Ctrl-D (EOF) now declines. Before, it accepted and applied patches.
  • Typeahead is flushed before the prompt, so Enter pressed during a scan no longer answers the next prompt.
  • The non-TTY defaults (Cleanup: no .socket residue, locks that never outlive a command, manifest-free vendored mode #247's contract) are kept, but their note respects --silent.
  • The cursor is restored when a dialoguer menu is interrupted with Ctrl-C.
• Color: one color_enabled policy (NO_COLOR / CLICOLOR / CLICOLOR_FORCE / TERM=dumb), also passed to dialoguer. Cells are padded before they are painted, so colored table rows line up.
• Text: plural, and a truncate that is char-safe and cuts at word boundaries.
• Core: a utils::notice quiet switch. Info advisories (the proxy notice) are muted under --silent/--json and print once per process instead of 2–3 times. Warnings (token shape) are muted only by --silent.

Per-command polish

Covers scan (report-only / agent / hosted / vendored), get, apply, rollback, remove, vendor, repair, list, lock waits, --update, the update notifier, vex and setup:

• Counted nouns instead of (s).
• Consistent Error: / Warning: prefixes; progress and warnings go to stderr.
• --silent is errors-only, but a run that fails still prints why.
• Output that came out in HashMap order is now sorted.
• --help no longer shows developer notes (now pinned by help_text_hygiene.rs across every subcommand page).
• Real bugs fixed along the way:
  • get --dry-run and vex --dry-run used to write files; they no longer do.
  • vex -O - used to create a file named -.
  • scan --json could stop at an interactive menu.
  • API errors now show the server's message instead of the raw JSON body.

Built on top of #247, which is on main now. #247's behavior and contract are unchanged. The merge was checked by running 46 flows side by side against #247's binary: exit codes, the final .socket/ trees, and the --json shapes were identical. Only the human-readable wording differs.

Test plan

• Unit tests for every terminal-UI path:
  • StatusLine byte output, including the exact regression above, shorter-after-longer, println while active, clear on drop, no escapes off a TTY, and multibyte width truncation;
  • the color_enabled truth table;
  • colored/plain cell alignment;
  • confirm_with for empty input, y/Y/yes/n, garbage, EOF, invalid UTF-8, and non-interactive with and without --silent;
  • plural and truncate;
  • per-command format_* helpers.
• PTY integration tests: typeahead discarded, Ctrl-C restores the cursor, SIGINT-ignored menu cancels cleanly, debug lines kept off the status line.
• cargo test -p socket-patch-cli -p socket-patch-core --no-fail-fast: 0 failures. Counts: core 4191 passed; cli 3543 passed. The known update_notifier_e2e::grace_budget_bounds_command_latency load flake passes when run on its own.
• cargo clippy -p socket-patch-cli -p socket-patch-core --all-targets -- -D warnings is clean. This also clears 9 lints Rust 1.93 raised in files this PR doesn't otherwise touch.
• Four fresh reviewers ran every command end to end under a pty and through pipes; everything they found is fixed or listed below.
• Windows: the console VT probe and FlushConsoleInputBuffer typeahead path only compile under cfg(windows). They were checked in a stand-alone crate, but not in a full Windows build. CI's Windows leg is the first real run.

Deferred (left out to keep scope; each is a product or contract call)

• High, bug on main: hosted scan treats an unreadable or missing vendor ledger as "nothing vendored". Found by reading the code; not reproduced. It needs detection of file:.socket/vendor entries.
• JSON contract changes: unifying the error shape to {code, message}, and per-purl events for partial apply.
• Behavior changes:
  • vendor --revert --dry-run drift prediction;
  • taking the lock before the vendored download phase;
  • skipping the per-file blob fetch when a diff archive exists.
• Tested wording: long advisory paragraphs shared with warnings[].detail; the ./ path prefix across commands; setup --check --silent; exit 1 on a declined --update.

🤖 Generated with Claude Code

---

Note

Medium Risk
Touches interactive prompts, progress rendering, and dry-run paths across most subcommands; behavior is heavily tested but Windows console paths are CI-dependent and several contract/doc tweaks describe user-visible output changes.

Overview
Replaces indicatif and scattered output helpers with a single crates/socket-patch-cli/src/ui/ module: a testable StatusLine for progress (self-clearing \r redraws, no drawing off-TTY/--json/--silent/debug/TERM=dumb), shared prompts (EOF declines, typeahead flush—including Windows FlushConsoleInputBuffer), color policy (NO_COLOR / CLICOLOR*), and plural / truncate / padded table cells.

Human-facing behavior is aligned across commands: proper singular/plural wording, Error: / Warning: on stderr, sorted formerly-random output, --help grouped under “Global options” without dev notes, and --silent still surfacing failure reasons. Bug fixes: get --dry-run (all modes, including agent) and vex --dry-run no longer mutate disk; vex -O - writes to stdout; scan --json no longer blocks on menus; API errors show server messages instead of raw JSON.

Docs/contracts (CHANGELOG, README, CLI_CONTRACT.md) are updated to match (rollback prompt copy, non-TTY scan/hosted notes, get narrowing display, VEX/list warnings, npm update hints, new error/warning codes). Dependencies: drop indicatif, add console + windows-sys on Windows.

^{Reviewed by Cursor Bugbot for commit 37e8d06. Configure here.}