Skip to content

Fix/failed builds - #16

Merged
pr0uxx merged 3 commits into
mainfrom
fix/failed-builds
Sep 18, 2026
Merged

pr0uxx merged 3 commits into
mainfrom
fix/failed-builds

Conversation

@pr0uxx

@pr0uxx pr0uxx commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Alpha releases were not being tagged as alpha, causing subsequent releases on other channels to fail. This PR aims to fix that.

This PR also aims to fix socket advanced security scan failing due to receiving 403 when trying to write a PR comment. The correct permission should be issue:write as opposed to pull_request:write as github internally considers issues and PRs to be the same thing...sort of. For example #15 automatically redirects to a PR.

Type Of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Documentation update
  • CI/CD or build change
  • Dependency update

Activities Checklist

Code Quality

  • I reviewed my own code.
  • I kept changes focused and removed dead code.
  • I followed repository conventions and naming.
  • I added or updated comments where behavior is non-obvious.

Testing And Validation

  • I ran npm run validate:package.
  • I added or updated tests for the changed behavior.
  • I verified no existing tests regressed.

Coverage

  • Coverage impact is acceptable for this change.
  • If coverage decreased, I explained why in this PR.

Security And Safety

  • I did not introduce secrets, tokens, or credentials.
  • Inputs are validated and error handling is appropriate.
  • Dependency changes were reviewed for risk.

Documentation

  • I updated README/docs when behavior or usage changed.
  • I updated examples if needed.

Release Impact

  • This change is backward compatible.
  • If breaking, I documented migration steps.
  • I considered versioning impact (patch/minor/major).

@pr0uxx pr0uxx self-assigned this Sep 18, 2026
Copilot AI lite review requested due to automatic review settings September 18, 2026 11:12
@github-actions

Copy link
Copy Markdown

🟢 Coverage Report

Metric Coverage Threshold Covered
Statements 95.3% 95% 508/533
Branches 87.98% 85% 337/383
Functions 100% 99% 125/125
Lines 95.38% 95% 496/520

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pr0uxx
pr0uxx merged commit c6bdd27 into main Sep 18, 2026
7 of 9 checks passed
@pr0uxx
pr0uxx deleted the fix/failed-builds branch September 18, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants