Skip to content

Lab-2143 CI Fixes - #3

Merged
pr0uxx merged 5 commits into
mainfrom
LAB-2143-LogEngine-extremely-decoupled-from-shield
Jul 30, 2026
Merged

pr0uxx merged 5 commits into
mainfrom
LAB-2143-LogEngine-extremely-decoupled-from-shield

Conversation

@pr0uxx

@pr0uxx pr0uxx commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Pinned socketsecurity to 2.5.5 in Security-Reachability.yml to avoid transient CI failures caused by newly released @coana-tech/cli dependencies still inside Socket's package-age cooldown window. Added detailed maintainer guidance on when and how to safely bump the pin, including publish-date checks and rollback instructions if ETARGET/notarget errors return.

Stopped configuring npm.pkg.github.com globally in CI setup by removing the Node scope/registry settings from shared workflow setup. Instead, target GitHub Packages explicitly on the GitHub publish command with --registry, so installs and other npm operations keep the default npmjs registry while package publication still goes to both registries as intended.

Type Of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Documentation update
  • CI/CD or build change
  • Dependency update

Activities Checklist

Code Quality

  • I reviewed my own code.
  • I kept changes focused and removed dead code.
  • I followed repository conventions and naming.
  • I added or updated comments where behavior is non-obvious.

Testing And Validation

  • I ran npm run validate:package.
  • I added or updated tests for the changed behavior.
  • I verified no existing tests regressed.

Coverage

  • Coverage impact is acceptable for this change.
  • If coverage decreased, I explained why in this PR.

Security And Safety

  • I did not introduce secrets, tokens, or credentials.
  • Inputs are validated and error handling is appropriate.
  • Dependency changes were reviewed for risk.

Documentation

  • I updated README/docs when behavior or usage changed.
  • I updated examples if needed.

Release Impact

  • This change is backward compatible.
  • If breaking, I documented migration steps.
  • I considered versioning impact (patch/minor/major).

Linked Work

Notes For Reviewers

  • There still could be further failures. This should fix sfw npm i failing and reachability analysis failing but does not guarantee to fix further step failures in workflows.

pr0uxx added 2 commits July 30, 2026 09:15
Pin `socketsecurity` to `2.5.5` in `Security-Reachability.yml` to avoid transient CI failures caused by newly released `@coana-tech/cli` dependencies still inside Socket's package-age cooldown window. Added detailed maintainer guidance on when and how to safely bump the pin, including publish-date checks and rollback instructions if ETARGET/notarget errors return.
Stop configuring npm.pkg.github.com globally in CI setup by removing the Node scope/registry settings from shared workflow setup. Instead, target GitHub Packages explicitly on the GitHub publish command with `--registry`, so installs and other npm operations keep the default npmjs registry while package publication still goes to both registries as intended.
@github-actions

Copy link
Copy Markdown

🟢 Coverage Report

Metric Coverage Threshold Covered
Statements 96.45% 95% 381/395
Branches 88.85% 85% 255/287
Functions 100% 99% 106/106
Lines 96.6% 95% 370/383

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts CI workflows to reduce transient failures in security scanning and to avoid globally overriding npm’s registry configuration during CI, while still publishing the package to GitHub Packages and npm as intended.

Changes:

  • Pin socketsecurity in the reachability workflow to avoid ETARGET/notarget failures caused by too-new transitive npm dependencies.
  • Stop configuring npm.pkg.github.com globally via the shared CI setup action.
  • Publish to GitHub Packages by explicitly passing --registry=https://npm.pkg.github.com to npm publish.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/Security-Reachability.yml Pins socketsecurity and adds maintainer guidance to reduce transient reachability scan failures.
.github/workflows/Publish.yml Removes the Node setup scope value as part of de-scoping global registry configuration.
.github/workflows/Build.yml Publishes to GitHub Packages using an explicit --registry argument (instead of global registry config).
.github/actions/setup-ci/action.yml Removes global GitHub Packages registry/scope configuration from shared CI setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/Security-Reachability.yml Outdated
Comment thread .github/workflows/Security-Reachability.yml
Comment thread .github/workflows/Build.yml Outdated
pr0uxx added 3 commits July 30, 2026 09:51
Add a new `update-reachability-pin` script that fetches PyPI release metadata for `socketsecurity`, selects the latest non-yanked stable version at least 24 hours old, and updates the pinned version in `Security-Reachability.yml`. `validate:package` now runs this updater first, while a new `validate:package:skip-reachability` command preserves CI behavior by avoiding workflow file edits during build validation. The Build workflow was updated to use the skip variant, and the reachability workflow comments now document the automated pinning approach.
Update the Build workflow’s GitHub Packages publish step to explicitly configure `//npm.pkg.github.com/:_authToken` from `NODE_AUTH_TOKEN` before running `npm publish`. This makes authentication explicit and avoids publish failures when npm does not automatically pick up the token from environment alone.
@pr0uxx
pr0uxx merged commit 5066735 into main Jul 30, 2026
8 checks passed
@pr0uxx
pr0uxx deleted the LAB-2143-LogEngine-extremely-decoupled-from-shield branch July 30, 2026 09:11
@pr0uxx pr0uxx changed the title Lab 2143 log engine extremely decoupled from shield Lab-2143 CI Fixes Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants