add refresh metadata - #868
Open
SharonStrats wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Wire the handler into shared authentication initialization so component-based restores are covered.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds authorization metadata refresh handling for restored authentication sessions.
Changes:
- Registers a
sessionRestorelistener. - Flags authorization metadata after restoration.
File summaries
| File | Summary |
|---|---|
src/login/login.ts |
Adds session restore metadata invalidation, but the listener is not wired into the component-based restore path. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+745
to
+746
| authSession.events.on('sessionRestore', () => { | ||
| solidLogicSingleton.store.updater.flagAuthorizationMetadata() as any |
SharonStrats
force-pushed
the
refresh-metadata
branch
from
September 12, 2026 11:40
4dd551a to
e3abb18
Compare
…istry@5.0.0-0) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing from the restore session flow, it only happens on the login flow.