Repository navigation
PREQ-8673: Increase legacy build-number migration buffer to 10000 - #351
Merged
Merged
Conversation
v1 already published far more than 1000 numbers into Artifactory after the property snapshot. A 10000 gap keeps v2 from re-claiming those numbers during migration.
|
hedinasr
marked this pull request as ready for review
September 17, 2026 14:33
julien-carsique-sonarsource
approved these changes
Sep 17, 2026
Code Review ✅ Approved🟡 Medium risk Increases the legacy build-number migration buffer from 1000 to 10000 to prevent v2 from re-issuing numbers already published to Artifactory when repos continue publishing with v1 after the initial snapshot. Shellspec test updated accordingly. No issues found. VerificationFunctional validation No results Rules No rules evaluated Auto-approval Not enabledOptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PREQ-8673: Increase the v1→v2 migration seed buffer so new claims skip numbers already published to Artifactory.
Why
When no
refs/build-number/*exist yet, v2 seedsMAX_CLAIMEDfrom the legacy GitHubbuild_numberproperty plus a buffer. The buffer was 1000. Repos such assonarcloud-webappkept publishing with v1 after that snapshot, so v2 later re-issued numbers Artifactory already had.multiRepoPromotethen 500s (Multiple builds found for sonarcloud-webapp#N).Change
legacy + 10000instead oflegacy + 1000.42 + 1000 + 1 = 1043to10043.This only affects the first claim in a repo that still has no
refs/build-number/*. Repos that already have those refs are unchanged.Test plan
shellspec spec/get_build_number_spec.sh --shell bash— 18 examples, 0 failures