Skip to content

[DO NOT MERGE] BUILD-12912: Default Repox resolution to the production Edge - #358

Closed
bwalsh434 wants to merge 2 commits into
masterfrom
feat/bwalsh/BUILD-12912-default-repox-internal
Closed

bwalsh434 wants to merge 2 commits into
masterfrom
feat/bwalsh/BUILD-12912-default-repox-internal

Conversation

@bwalsh434

@bwalsh434 bwalsh434 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

BUILD-12912: Actions that already expose repox-url now resolve dependencies through https://repox-internal.sonar.build by default. Explicit SaaS and dev Edge overrides remain supported. Updates all 12 input defaults and their documentation; deployment, publication, build info, and promotion continue using SaaS Repox.

Ticket: https://sonarsource.atlassian.net/browse/BUILD-12912

Dependencies and release prerequisites

Stacked on #357 for production Vault routing and Edge-issued reader tokens. Merge that dependency first, then retarget this PR to master. Keep this PR in draft until the production Edge Vault engine is seeded and configured and authenticated downloads have been validated from the intended runners. Runners need access to the internal endpoint; callers without that access must explicitly select repox-url: https://repox.jfrog.io.

Test plan

  • Passed all 47 focused ShellSpec examples for npm, pip, Poetry, uv, and NuGet configuration.
  • Verified all 12 existing action defaults and unchanged caller input forwarding by parsing the YAML manifests.
  • Passed applicable pre-commit checks, including strict YAML and Markdown linting.
  • Passed DEEP analysis of all 13 modified files with no issues.
  • Before release, run representative workflows without a repox-url override against the production Edge and validate private dependency authentication; repeat with explicit SaaS and dev Edge overrides.

CI tooling setup

The shell tests, release-channel schema validation, and build-number aggregation explicitly use SaaS Repox for their config-npm tooling setup. These jobs validate unrelated functionality and can run before production Edge activation. The action defaults remain on the production Edge; authenticated default-endpoint integration validation is still required before release.

@bwalsh434

Copy link
Copy Markdown
Contributor Author

[From Codex] Confirmed Gitar's Vault-access finding in both failing jobs: production Vault denies development/artifactory-edge-prod/token/SonarSource-ci-github-actions-public-reader. The required mount/role/policy preparation and activation are already covered by https://github.com/SonarSource/re-terraform-aws-vault/pull/9759 and https://github.com/SonarSource/re-terraform-aws-vault/pull/9760 under BUILD-12911. This PR remains draft with [DO NOT MERGE] and is stacked on #357. Apply the preparation, bootstrap and activation sequence, then rerun the default-endpoint integration checks. No additional policy change belongs in this repository, and an SaaS override in those tests would bypass the new default we need to validate.

@bwalsh434
bwalsh434 force-pushed the feat/bwalsh/BUILD-12912-default-repox-internal branch from fd1e133 to 26f9c8f Compare October 6, 2026 20:30
@bwalsh434
bwalsh434 force-pushed the feat/bwalsh/BUILD-12912-default-repox-internal branch from 26f9c8f to dcf6108 Compare October 6, 2026 20:30
@bwalsh434

Copy link
Copy Markdown
Contributor Author

[From Codex] Updated the three failing workflows to explicitly use SaaS Repox for npm tooling setup. This lets shell tests, schema validation, and build-number aggregation run before Edge activation. All 12 action defaults remain on the production Edge. Workflow schema validation, strict YAML lint and actionlint pass locally; authenticated default-endpoint validation remains a release prerequisite. CI is rerunning.

@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

Base automatically changed from feat/bwalsh/BUILD-12911-centralize-edge-token-issuance to master October 9, 2026 19:48
@bwalsh434

Copy link
Copy Markdown
Contributor Author

Closing this PR in favor of #359

@bwalsh434 bwalsh434 closed this Oct 12, 2026
@gitar-bot

gitar-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Twelve actions switch default dependency resolution from SaaS to the production Edge.

Defaults Repox resolution to the production Edge for 12 actions that expose repox-url, while preserving explicit SaaS and dev Edge overrides. All 47 ShellSpec tests pass, YAML manifests are verified, and DEEP analysis found no issues. No issues found.

Verification

Functional validation No results

Rules No rules evaluated

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant