Repository navigation
BUILD-13259: Remove copied action links on Windows runners - #371
Merged
Merged
Conversation
Git Bash on Windows copies directories for ln -s unless native symlinks are enabled, so the cleanup's rm -f fails with 'Is a directory'. rm -rf removes both a copy and a real symlink, never the symlink target.
|
hedinasr
marked this pull request as ready for review
October 27, 2026 10:46
SamirM-BE
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUILD-13259
On Windows runners, Git Bash's
ln -sfcopies the directory unless native symlinks are enabled. The "Clean up local action symlinks" step then fails, which fails the whole action after it has configured everything:Seen with
config-npm@2.5.0onwarp-custom-windows-2022-sin sales-platform#1063. The registry, token and build number were all set before the cleanup failed.The cleanup now uses
rm -rfin config-npm, config-poetry, config-uv, build-npm, build-poetry and build-yarn. On Linux and macOS,rm -rfon a symlink path without a trailing slash removes only the link, not its target.Test plan
Frontend (Windows)andRust (Windows)pass with config-npm pinned to this branch's commit_actionsare intact