Skip to content

RC-352: Update ruling test for the relocated sonar-server fixture - #161

Draft
romainbrenguier wants to merge 1 commit into
masterfrom
romain/RC-352-move-sonar-server
Draft

romainbrenguier wants to merge 1 commit into
masterfrom
romain/RC-352-move-sonar-server

Conversation

@romainbrenguier

Copy link
Copy Markdown
Contributor

Summary

Expected baselines

No baseline changes are needed. The project key (org.sonarsource.sonarqube:sonar-server) and the expected directory (its/ruling/src/test/resources/sonar-server) are unchanged. Component keys are relative to the Maven module base directory, which is still sonar-server.

Dependency

Merge SonarSource/ruling_java#18 first, then repoint the submodule to the merged commit if it differs. Companion of SonarSource/sonar-java#6436.

Note

The submodule bump (c581e47 → d4109b1) also includes ruling_java commits #10–#17 (a guava maven-bundle-plugin version declaration, eclipse-jetty submodule pointer updates, and new projects that this repo doesn't use). sonar-java already runs with them.

Part of RC-352

🤖 Generated with Claude Code

Bump its/sources to SonarSource/ruling_java#18, which moves the
sonar-server fixture from sonarqube-6.5/server/sonar-server to the
repository root, and point JavaRulingTest.sonarqube_server at the new
location.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RC-352

@sonarqube-next

Copy link
Copy Markdown

@gitar-bot

gitar-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Relocating the sonar-server fixture changes the integration test’s Maven input, which could alter ruling-test coverage or results.

Updates the its/sources submodule to the relocated sonar-server fixture and repoints JavaRulingTest.sonarqube_server to ../sources/sonar-server/pom.xml. No baseline changes are required since the project key and expected directory are unchanged. No issues found.

Verification Rules 1/1 met PRs 3 inspected

Functional validation No results

Rules 1 passed 2 not applicable

✅ Repository license compliance

Broader impact PRs 3 inspected
Cross-PR 3 PRs inspected 0 open impacts

PR 18: RC-352 Move sonar-server ruling project to the repository root Inspected
PR 162: RC-793 Update ruling test for the relocated sonar-server fixture Inspected
PR 6436: RC-352 Update ruling tests for the relocated sonar-server fixture Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant