Skip to content

RC-352 Update ruling tests for the relocated sonar-server fixture #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
romainbrenguier wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

RC-352 Update ruling tests for the relocated sonar-server fixture #6436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,9 @@ private static String getFileLocationAbsolutePath(FileLocation location) {

@Test
public void sonarqube_server() throws Exception {
// sonarqube-6.5/server/sonar-server (v.6.5)
String projectName = "sonarqube-6.5";
MavenBuild build = test_project(projectName, projectName + "/server", "sonar-server")
// sonar-server (v.6.5)
String projectName = "sonar-server";
MavenBuild build = test_project(projectName)
Comment on lines +401 to +403

@gitar-bot gitar-bot Bot Oct 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Quality: AGENTS.md still lists sonarqube-6.5 as a ruling project

This PR renames the ruling project to sonar-server: the fixture moves, the expected baselines move to expected/sonar-server, and projectName in JavaRulingTest.sonarqube_server changes. AGENTS.md:299 still lists sonarqube-6.5 among the ruling projects. The same section says <projectKey> is the project's folder name under its/sources/ and that expected files live in expected/<project>/. Following it now leads to a directory and key prefix that no longer exist. That list is the documented ruling project names, so it should be updated to sonar-server.

Replace the stale project name in AGENTS.md.:

Ruling tests validate that rule fixes don't break existing true positives. They run the analyzer against real-world Java projects (`guava`, `commons-beanutils`, `eclipse-jetty`, `sonar-server`, `jboss-ejb3-tutorial`, `regex-examples`, `mall`) and compare results to expected baselines.
  • Apply fix

Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎

.setProperty("sonar.java.fileByFile", "true");
executeBuildWithCommonProperties(build, projectName);
}
Expand Down
5 changes: 5 additions & 0 deletions its/ruling/src/test/resources/expected/sonar-server/java-NoSonar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"sonar-server:src/main/java/org/sonar/server/ui/PageDecorations.java": [
46
]
}
Loading
Loading