[david-schroeter]

---

Summary by Gitar

• Bug fix:
  • Extended RedundantJumpCheck to visit lambda expressions, so redundant returns in lambda bodies are reported
• Tests:
  • Added regression cases covering nested lambdas, loops, conditional returns, and finally blocks
• Messages:
  • Issue messages now name the jump, such as Remove this redundant continue.

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-7280

[david-schroeter]

/pvf

[hashicorp-vault-sonar-prod]

📊 Performance Validation complete
🆕 12 new · 🗑️ 0 lost issues
View dashboard

Projects with unexpected PVF results:

• crate

[rombirli]

LGTM, small suggestions

[rombirli]

🚀

[gitar-bot]

Code Review ✅ Approved 1 closed / 1 findings

🟡 Medium risk · Extending S3626 to analyze lambda control-flow graphs changes Java diagnostics and could incorrectly flag non-redundant jumps as removable.

Extends RedundantJumpCheck to visit lambda expressions so redundant returns inside lambda bodies are reported, with regression tests covering nested lambdas, loops, conditional returns, and finally blocks. No issues found.

✅ 1 closed

Closed: Performance: CFG is built for every expression lambda, which can't hold a redundant jump

📄 java-checks/src/main/java/org/sonar/java/checks/RedundantJumpCheck.java:45-55
LambdaExpressionTree.body() is never null, so the body != null guard doesn't filter anything for lambdas. As a result, every lambda in the analyzed code goes through cfg(). For expression lambdas such as x -> x + 1 or () -> System.out.println(...), LambdaExpressionTreeImpl.cfg() runs CFG.buildCFG(singletonList(body)) (LambdaExpressionTreeImpl.java:100-104). An expression body can't contain a return or continue terminator, and any nested block lambda is visited on its own, so this CFG is built and then thrown away. Stream-heavy code has a lot of these lambdas. The fix is to analyze a lambda only when its body is a BLOCK. That also removes the second instanceof dispatch.

Verification Rules 1/1 met Repos 4 inspected · PRs 2 inspected

Functional validation No results

Rules 1 passed 2 not applicable

✅ Repository license compliance

Broader impact Repos 4 inspected PRs 2 inspected

Cross-repo 4 repositories inspected 0 open impacts

SonarSource/sonarqube Inspected
SonarSource/sonarlint-intellij Inspected
SonarSource/sonarlint-vscode Inspected
SonarSource/sonar-java-symbolic-execution Inspected

Cross-PR 2 PRs inspected 0 open impacts

PR 2033: SLI-3034 SLI-3035 analyzer updates Inspected
PR 1281: SLVSCODE-2040 SLVSCODE-2041 analyzer updates Inspected

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube