SLE-1476 SubmitReview: Use Vault token#1040
SLE-1476 SubmitReview: Use Vault token#1040pavel-mikula-sonarsource wants to merge 1 commit intomasterfrom
Conversation
SummaryThis PR migrates the SubmitReview workflow from using GitHub Actions' built-in What reviewers should knowKey changes:
Watch for:
|
There was a problem hiding this comment.
LGTM! ✅
Clean, minimal change. The updated SubmitReview.yml is now a near-exact mirror of RequestReview.yml — same Vault secret paths, same fromJSON token extraction, same permissions block (only id-token: write). The pull-requests: read removal is correct: it was only needed for the built-in GITHUB_TOKEN, which is no longer used here.
With the latest automation changes, we need the Vault-based token now. It's the same token as the one in RequestReview.yml file. Please take care of merging this, I have 200+ repos to update.