chore(create-app): clean up docs after #824#832
Merged
Conversation
- Restore the helpful comment hint on the D1 database_id line in starter wrangler.toml. - Drop the misleading --binding flags from the create-app README and starter README; without --update-config they don't wire up wrangler.toml, and the surrounding docs already tell users to copy the values manually. - Restore trailing newlines on both README files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up to #824 (which is already merged — thanks @author):
# Run: wrangler d1 create my-sonicjs-dbcomment in the starterwrangler.tomlso fresh-install users still get the inline hint about how to populatedatabase_id.--binding DB/--binding MEDIA_BUCKETflags from the create-app README and starter README. The flags are valid forwrangler d1 create/wrangler r2 bucket create, but they're effectively no-ops without--update-config, and the surrounding docs already instruct users to copy the values intowrangler.tomlmanually — so the flags are misleading rather than helpful.No runtime code changes.
Test plan
git diffreviewed — touches only the three intended fileswrangler.tomlrendered in fresh installs still shows the D1 hint comment🤖 Generated with Claude Code