ci: rename "RELAY interop gate" step to name what it runs (INTEROP-07) - #53
Merged
Conversation
The step only drives `relay interop --protocol LIN` against RELAY's own embedded LIN golden vectors -- self-consistency against RELAY's own reference conversion, not third-party interoperability against an independent LIN peer. Per SoundMatt/RELAY docs/INTEROP-ARCHITECTURE.md's naming discipline, `*-interop` is reserved for a check against a peer this repo did not build; a step invoking only RELAY's own CLI should say so. Not previously flagged: the design doc's own current-state inventory only called out rust-RCP and rust-LIN as naming violators (at the job level) and missed this repo's step-level mislabeling entirely -- re-verified directly against this repo's real ci.yml rather than trusting that inventory. The enclosing job (`relay-conform`) was already correctly named; only this one step's display name was misleading. Pure rename, no behavior change: the underlying `run:` command is unchanged. Manual duplicate-job-ID scan (9 job ids, 9 unique) since `yaml.safe_load` alone can't be trusted to catch that class of bug. Verified locally against the pinned relay v2.0.4 build this job installs: built cpp-lin-cli from a clean cmake+ninja configure, then confirmed `relay conform --strict` and `relay interop --protocol LIN` both still PASS. SoundMatt/RELAY THEME-K (#125), docs/INTEROP-ARCHITECTURE.md shipping order item 2. Companion fix: SoundMatt/go-LIN#77. Sign-off: DCO Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Owner
Author
|
Merged. Fresh-clone re-verify: built cpp-lin-cli from a clean cmake+ninja configure of the merged commit, confirmed Companion fix: SoundMatt/go-LIN#77. SoundMatt/RELAY THEME-K (#125), docs/INTEROP-ARCHITECTURE.md shipping order item 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "RELAY interop gate" step only drives
relay interop --protocol LINagainst RELAY's own embedded LIN golden vectors — self-consistency, not third-party interoperability. Renamed to name the actual invocation perdocs/INTEROP-ARCHITECTURE.md's naming discipline. The enclosing job (relay-conform) was already correctly named; only this step's display name was misleading.Not previously flagged: the design doc's own inventory only called out rust-RCP/rust-LIN as naming violators (at the job level) and missed this repo's step-level mislabeling.
Verification
Pure rename, no behavior change: built
cpp-lin-clifrom a clean configure, confirmedrelay conform --strictandrelay interop --protocol LINboth still PASS against pinned relay v2.0.4. Manual duplicate-job-ID scan: 9 job ids, 9 unique.SoundMatt/RELAY THEME-K (#125),
docs/INTEROP-ARCHITECTURE.mdshipping order item 2. Companion fix: SoundMatt/go-LIN#77.Sign-off: DCO