Skip to content

ci: gate on relay interop's real exit code instead of grep-scraping stdout #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoundMatt merged 1 commit into from
Aug 21, 2026
Merged

ci: gate on relay interop's real exit code instead of grep-scraping stdout #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,14 +278,18 @@ jobs:
- name: RELAY conformance (strict)
run: relay conform --strict ./target/release/rust-lin

- name: RELAY interop (LIN golden vectors — must be EQUIVALENT)
run: |
interop_out=$(relay interop ./target/release/rust-lin 2>&1) || true
echo "$interop_out"
if echo "$interop_out" | grep -A2 "(LIN)" | grep -qE "ERROR|FAIL"; then
echo "FAIL: one or more LIN golden vectors not EQUIVALENT"
exit 1
fi
- name: RELAY interop --strict --protocol LIN (LIN golden vectors — must be EQUIVALENT)
# Was previously `interop_out=$(relay interop ... 2>&1) || true` piped
# through a grep of stdout instead of the command's real exit code —
# that silently tolerated both a genuinely broken run and any future
# change to relay interop's output format (SoundMatt/RELAY THEME-K,
# INTEROP-04). --protocol LIN restricts the check to rust-lin's own
# protocol and --strict fails on a missing convert rather than
# treating it as an innocuous skip; the command's real exit code now
# gates this step directly, verified locally against the pinned
# relay v2.0.4 build this job installs (EQUIVALENT/PASS/exit 0 on a
# real convert implementation, FAIL/exit 1 on a broken one).
run: relay interop --strict --protocol LIN ./target/release/rust-lin

# ── DCO sign-off check ─────────────────────────────────────────────────────
dco:
Expand Down
Loading