MMA-10643. set proxy session true even on cancelled operations#53
Open
bitsikas wants to merge 1 commit intoexim-4.94.2+fixes+se+encrfrom
Open
MMA-10643. set proxy session true even on cancelled operations#53bitsikas wants to merge 1 commit intoexim-4.94.2+fixes+se+encrfrom
bitsikas wants to merge 1 commit intoexim-4.94.2+fixes+se+encrfrom
Conversation
bitsikas
requested review from
a team,
alin-f-tache and
cosmingrz
and removed request for
a team
alin-f-tache
approved these changes
Mar 4, 2026
cosmingrz
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When connection aborts the log displays the local interface instead of the attempted socks proxy interface
How
Mark that a proxy was used even if the connection was unsuccesful.
Note
Low Risk
Low risk: a one-line state flag change affecting only SOCKS proxy logging/metadata, not SMTP delivery logic.
Overview
Ensures SOCKS connections are recorded as using a proxy as soon as the TCP connection to the SOCKS server succeeds.
proxy_sessionis now set toTRUEimmediately aftersmtp_sock_connect()connects to the proxy (alongsideproxy_local_address/proxy_local_port), so later handshake failures or aborted operations still log proxy context correctly.Written by Cursor Bugbot for commit 0df7539. This will update automatically on new commits. Configure here.