Fix sending Transmission content with template_id.#166
Open
Tang8330 wants to merge 2 commits intoSparkPost:masterfrom
Open
Fix sending Transmission content with template_id.#166Tang8330 wants to merge 2 commits intoSparkPost:masterfrom
Tang8330 wants to merge 2 commits intoSparkPost:masterfrom
Conversation
|
I came here to report the same problem and propose a similar fix. @Tang8330 were you able to find a workaround so you can reliably send your transmissions? Otherwise calls to It seems like the only(?) workaround for using stored templates with Sparkpost is to simply not use this Golang library? |
Author
|
@chrsmith I fixed the problem on my fork and we're using that in Production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current logic is flawed in 2 ways.
map[string]stringtypes. Logic would early return when it foundtemplate_idbased on [1], but because iterating keys over a map is not deterministic, it would fetchCCand then err out because it'smap[string]stringnotstring