Fix file size calculation in write_binary()#4607
Open
grahamfindlay wants to merge 2 commits into
Open
Conversation
`write_binary()` was determining the file size and seek offests based on the source dtype's itemsize, but the data is cast to the target dtype before writing. This means that if the target dtype has a different itemsize than the source dtype, a corrupted file of the wrong size and layout was produced. The solution was just just use the target dtype's itemsize for all file size and seek offset calculations.
alejoe91
approved these changes
Jun 4, 2026
Member
|
@grahamfindlay I extended the signature of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_binary()was determining the file size and seek offests based on the source dtype's itemsize, but the data is cast to the target dtype before writing. This means that if the target dtype has a different itemsize than the source dtype, a corrupted file of the wrong size and layout was produced.The solution was just just use the target dtype's itemsize for all file size and seek offset calculations.