Conversation
These are the versions that are installed by pip without any "==x.y.z" in the requirement.txt with python 3.12.3 (ubuntu 24.04).
note: I have absolutely no knowledge of chinese or any non ideogram languages. I added space so the `` is correctly detected and the warning is gone. Perhaps a better handling when a ` (` special ( character would give a better look.
v5 is only 18h old it's perhaps why it's not working.
The docker image use Debian 12 Bookworm, close the ubuntu 24.04 used in the CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested with an updated requirements.txt, updated CI with latest actions, ubuntu 24.04. It deploy on https://spinalhdl.github.io/SpinalDoc-RTD/dev/index.html . It seems that the English and Chinese version are working properly.
The diagrams are showing in both versions. I don't speak Chinese, but it seems the last master and new dev look pretty similar.
This update should let us avoid possible deprecation of the CI workflow at the end of this year.
Note that the pdf is not accessible as described in the documentation currently in master. I was not able to find where the pdf is generated. @Readon @jijingg @Tectu @Dolu1990 I don't know if a pdf version is necessary and really used by anyone. But perhaps in Chinese it is a big advantage due to layering, I don't known. I can invest some time to make it work again in a later PR. But if it's not really needed, I prefer to invest time in the html version.