Repository navigation
fix(stl-game-config): detect primary-display HDR and the gaming GPU correctly - #225
Merged
st0nefish-ci[bot] merged 1 commit intoOct 10, 2026
Conversation
…orrectly check_kde_hdr_enabled always returned false (ANSI codes in kscreen-doctor -o defeated the grep, and head -1 read an arbitrary output). detect_gpu_vendor's sysfs checks never matched (ls instead of cat) and only looked at card0, which is often the CPU's iGPU. - Parse kscreen-doctor -j with jq; report hdr of the enabled priority-1 output - Rank every /sys/class/drm card: NVIDIA > discrete AMD > Intel > AMD iGPU (amdgpu VRAM < 2 GiB = iGPU); nvidia-smi -L and vulkaninfo fallbacks - Vulkan fallback grep is now -q so matched lines no longer leak into the JSON - Add tests/stl-game-config/test-system-info.sh (14 cases) - Bump stl-game-config to 1.2.2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
st0nefish-ci
Bot
deleted the
worktree-bug-kde-hdr-detection-false-negative
branch
October 10, 2026 14:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two detection bugs in
stl-game-config'ssystem-info.sh.HDR (#182).
check_kde_hdr_enabledalways returnedfalse:kscreen-doctor -ocolorizes through a pipe, so
HDR: enablednever matched literally, andhead -1read whichever output was listed first rather than the primary. It nowparses
kscreen-doctor -jwithjqand reportshdrof the enabled output withpriority == 1.GPU vendor.
detect_gpu_vendor's sysfs checks never matched (lsof thevendor file instead of
cat) and only looked atcard0, which is often theCPU's iGPU (e.g. Ryzen iGPU as
card0, RTX 5090 ascard1). It now ranks every/sys/class/drm/cardN: NVIDIA > discrete AMD > Intel > AMD iGPU (amdgpu withVRAM < 2 GiB), falling back to
nvidia-smi -L(proprietary driver withoutnvidia-drm) and then
vulkaninfo.Review fixes: the Vulkan fallback grep is now
-q(matched lines leaked intothe JSON output), and the
nvidia-smifallback was restored after review.Note: the format-on-save hook reindented
system-info.shfrom 4 to 2 spaces —review it with whitespace hidden (
git diff -w).Test plan
tests/stl-game-config/test-system-info.sh— 14 cases (7 HDR fixtures viaa mocked
kscreen-doctor -j, 7 GPU fixtures viaSTL_DRM_ROOT), all passingbash .github/scripts/validate-all.sh— all checks pass{"gpu_vendor":"nvidia","compositor":"kde","kde_hdr_enabled":true}Fixes #182
🤖 Generated with Claude Code