Skip to content

feat(session): pause for user review before shipping the final unit - #229

Merged
st0nefish-ci[bot] merged 1 commit into
masterfrom
worktree-wip-pause-before-final-ship
Oct 17, 2026
Merged

st0nefish-ci[bot] merged 1 commit into
masterfrom
worktree-wip-pause-before-final-ship

Conversation

@St0nefish

Copy link
Copy Markdown
Owner

Summary

The #228 "bug me less" change made session-end ship the last unit first and only then ask for completion, so a one-PR session opened and merged its PR without the user seeing a summary. The stop now comes before the final ship.

  • session-end step 5 summarizes the work and caveats, then waits for the user's go via AskUserQuestion (Ship it / Make changes first; cancel through Other), so it can be answered remotely (/rc).
  • After the go: ship, watch CI, fix forward and re-merge if needed, clean up, then a final-state report. No second confirmation stop.
  • Earlier units of a multi-PR scope still land via the ship skill without asking. A one-PR session always pauses; a multi-PR scope pauses once, before the last PR.
  • Review gate: effort scales with change complexity; a triage agent (model matched to complexity) judges findings real/significant before anything is fixed; re-review only after significant fixes; at most three review/fix passes, then ask the user.
  • Spine, session-start/session-issue/session-orchestrate, the Copilot commands, and both READMEs updated to match. session plugin bumped to 4.11.0 (Claude + Copilot variants).

Test plan

  • bash .github/scripts/validate-all.sh passes (parity, plugin tests, structure, frontmatter, markdown, shell lint)
  • code-review medium: 7 findings, 3 judged real and fixed, 4 dropped as not real or minor
  • Prose-only change, not exercised in a live session; first real check is the next /session:session-end run

🤖 Generated with Claude Code

session-end used to ship the last unit and only then ask for completion,
so a one-PR session opened and merged its PR without the user seeing a
summary. The stop now comes before the final ship.

- session-end: new step 5 summarizes the work and caveats and waits for
  the user's go via AskUserQuestion (Ship it / Make changes first; cancel
  through Other); after the go it ships, watches CI, fixes and re-merges,
  cleans up, and ends with a final-state report
- review gate: effort scales with change complexity, a triage agent
  judges findings real/significant before any fix, re-review only after
  significant fixes, at most three review/fix passes then ask the user
- earlier units of a multi-PR scope still ship without asking
- spine, start/issue/orchestrate skills, Copilot commands and READMEs
  updated to match; session plugin bumped to 4.11.0 (Claude + Copilot)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@st0nefish-ci
st0nefish-ci Bot enabled auto-merge October 17, 2026 13:56
@st0nefish-ci
st0nefish-ci Bot merged commit 935f703 into master Oct 17, 2026
8 checks passed
@st0nefish-ci
st0nefish-ci Bot deleted the worktree-wip-pause-before-final-ship branch October 17, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant