Remove unused s3fs dependency#116
Merged
zqevans merged 1 commit intoStability-AI:mainfrom Dec 27, 2024
Merged
Conversation
Contributor
Author
|
For more context - doing |
Contributor
Author
|
@zqevans any opposition to this? |
Contributor
|
#139 is related. |
SelenaGeRuiqi
pushed a commit
to SelenaGeRuiqi/stable-audio-tools
that referenced
this pull request
May 29, 2025
Remove unused s3fs dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that it takes quite a while to download the various dependencies of
s3fsduringpip install, and it appears thats3fsis not actually referenced anywhere in the repo (see search). So no need to include insetup.py.