Fix operator precedence bug in condition unwrapping#233
Open
Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Open
Fix operator precedence bug in condition unwrapping#233Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Conversation
Add parentheses around the isinstance checks to ensure the condition correctly checks for single-element lists OR tuples, rather than the current buggy behavior of always unwrapping lists regardless of length. Fixes Stability-AI#221 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conditioners.pythat caused incorrect condition unwrapping behaviorA or B and CasA or (B and C), causing lists to always be unwrapped regardless of lengthThe Bug
Before (incorrect):
This unwraps:
After (correct):
This correctly unwraps:
This matches the intent described in the comment: "Unwrap the condition info if it's a single-element list or tuple"
Test plan
Fixes #221
🤖 Generated with Claude Code