-
Notifications
You must be signed in to change notification settings - Fork 100
feat(user card) - Update User card to new SHINE design (part 1) #2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 823cda0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey @ttaylor-stack , I did a quick glance through the code and it overall looked good to me. Looking at the UI elements I noticed an issue with gaps, though: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base should be using the 24x24 avatar size.
The padding in between the bling and the badge/rep number is created with a space character before the number. Should this be done with padding/gutter spacing instead? Would be 2px.
Is there any way to have 4px spacing in between badges when the count is showing vs 2px spacing when the count number isn't?
For responsive, when we need to wrap, I think we should keep certain blocks of info together (so the whole block wraps when the screen size is too short)
Got confused by my own section title — can we change this to "with user badges"?
OR — I'm wondering if we should also have a "with Bling" section OR should both of those just be in the Base section?
Should / could the Sizes be in the same section? Maybe in a table to get both descriptions or just the descriptions above separate by a paragraph and both sizes in the same code box?


This ticket cover part 1 of the user card updates.
The following things will be updated in Part 2:
Ticket
Figma