Refactor build structure and add noble.#126
Open
nzlosh wants to merge 6 commits intoStackStorm:masterfrom
Open
Refactor build structure and add noble.#126nzlosh wants to merge 6 commits intoStackStorm:masterfrom
nzlosh wants to merge 6 commits intoStackStorm:masterfrom
Conversation
skiedude
reviewed
Mar 10, 2026
build_image
Outdated
|
|
||
| function bootstrap_docker() | ||
| { | ||
| usdo apt-get update --quiet --quiet |
There was a problem hiding this comment.
- usdo > sudo
- Do we need --quiet twice?
Contributor
Author
There was a problem hiding this comment.
Good catch. I don't know about the double quiet, it was a copy paste from an existing command. I'm fine setting to a single quiet, it's a convenience function to install docker.
skiedude
reviewed
Mar 10, 2026
| cd st2packaging-dockerfiles/packagingbuild/focal | ||
| docker build -t stackstorm/packagingbuild:focal . | ||
| # ./build_image | ||
| Usage ./build_image <bootstrap|build [distro]> |
There was a problem hiding this comment.
probably worth mentioning what OS this build_image works on, as it looks to be deb only, I couldn't run this on my mac
Contributor
Author
There was a problem hiding this comment.
The ./build_image build jammy command should work on any *nix distro that has docker installed.
Contributor
Author
There was a problem hiding this comment.
I've added a note about bootstrap only supporting Ubuntu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.