STAC-24960 drop OCI base image labels#13
Draft
LouisLotter wants to merge 1 commit into
Draft
Conversation
Andreagit97
reviewed
Jun 9, 2026
|
|
||
| ARG BCI_VERSION=15.7-56.15 | ||
| FROM registry.suse.com/bci/bci-micro:${BCI_VERSION} | ||
| FROM registry.suse.com/bci/bci-micro:${BCI_VERSION} AS base |
Contributor
There was a problem hiding this comment.
to be honest i would simplify the whole thing by enforcing a convention. Dockerfiles that use this action should expose an argument ARG BASE_IMAGE= so that the detection is immediate and if the arg is not present also the failure is extremely clear. WDYT? @viliakov
LouisLotter
force-pushed
the
STAC-24960-fix-oci-base-resolution
branch
from
8c92b16 to
9fd5622
Compare
LouisLotter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop apply-oci-labels from emitting org.opencontainers.image.base.name and org.opencontainers.image.base.digest.
Why
The Hadoop publish job was blocked because the action tried to infer base image labels from a multi-stage Dockerfile and inspected an internal stage name as if it were a registry image. The previous version of this PR fixed that specific parser case, but review feedback correctly pointed out that the reusable publish action should not grow Dockerfile detection logic just to emit optional provenance labels.
Dropping these two labels removes the Dockerfile parsing, base-image registry lookup, Buildx precondition, and source-registry login from the publish path.
Compatibility
The related inputs (dockerfile, base-name, base-digest, registry-credentials) remain defined as deprecated no-ops for now, so existing callers that still pass them do not break while downstream workflows are cleaned up.
Validation