ci: bump nightly stand pin to xrpld 3.4.0~rc1+202609050006.e3c8996e-1 - #182
Merged
Merged
Conversation
Platonenkov
deleted the
nightly-watch/3.4.0-rc1-202609050006.e3c8996e-1
branch
September 7, 2026 14:18
Platonenkov
added a commit
that referenced
this pull request
Sep 7, 2026
…he nightly stand TestIClosedEndedVault, gated on LendingProtocolV1_1: a closed-ended vault through its three phases (deposit in subscription; tecEXPIRED / tecTOO_SOON in investment; withdrawal in redemption), an open-ended vault carrying no VaultKind on the ledger, and a VaultWithdraw to a deposit-authorized destination that is tecNO_PERMISSION without CredentialIDs and succeeds with them. The run caught a wrong constant: kMinInvestmentPeriod is 180 s since rippled #8151, not the 60 s of the original #7921. ValidateVaultCreate, its unit test and the docs now say three minutes. Found on the same stand and left for a follow-up: under LendingProtocolV1_1 LoanBrokerSet refuses an open-ended vault, and the whole Loan integration suite builds on open-ended ones - 18/18 of TestILoan fail there, identically on untouched dev. The CI stand (3.3.0) is unaffected. Verified on xrpld 3.4.0-rc1 (the #182 pin): TestIClosedEndedVault 3/3, TestIVault and TestICredential 25/25; TestU 1290/1290.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated bump by the nightly-pin-watch workflow: the nightly stand was pinned to a build 26d old.
.ci-config/Dockerfile.nightly:3.4.0~b0+202608111815.26cc683e-1->3.4.0~rc1+202609050006.e3c8996e-1.ci-config/rippled.batchv11.cfg:[features]/[amendments]regenerated from develope3c8996e, the commit that build was made fromAmendment changes
Added:
Removed:
definitions.json vs the new build
A
node-onlyfield here means the SDK is behind develop and needs a follow-up;local-onlyentries are informational.Verification
The stand was built and started from the new pin on the runner, and the AMM sentinel amendment came up enabled at genesis, so the regenerated config was accepted.
Why this matters: definitions-watch raises its stand from this pin, so a stale pin makes the weekly develop-drift check compare against the past.