Update Game Renamer - #233
Open
Inceptofn wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR advances the Steam-GameRenamer-Plugin git submodule pointer to a newer upstream commit so the plugin can be built successfully by the store CI (aligning with the upstream repo’s pnpm-based dependency setup).
Changes:
- Updated the
plugins/Steam-GameRenamer-Pluginsubmodule commit frome078a596f3ce1e43188ce27815e6fe905620fa89tof24a9eeeac350bf6ede9baa4af289e9d4d1cedef.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steam-GameRenamer-Plugin
Advances the submodule pointer from
e078a596(v1.0.0, the initial commit) tof24a9ee(currentmain).Why: The pinned commit predates the repo's
pnpm-lock.yamland.npmrc(added inec79f28f/fd712f11on Jun 9), so the store CI build fails with a fresh dependency resolution (TypeError: Cannot read properties of undefined (reading 'ES2015')in@rollup/plugin-typescript) and no zip is ever uploaded. This leaves the plugin showing "Size: NaN" and "This plugin does not have a valid build for your OS." in the client.The new commit builds cleanly with plain
pnpm install && pnpm run buildunder pnpm v10 (verified locally).Task Checklist
Developer
Plugin Functionality
Backend Configuration
Community Contribution
Testing Instructions