Update samples to use Steeltoe package for git.properties - #473
Update samples to use Steeltoe package for git.properties#473bart-vmware wants to merge 4 commits into
Conversation
549e027 to
9230f79
Compare
9230f79 to
571c009
Compare
TimHess
left a comment
TimHess
left a comment
There was a problem hiding this comment.
I think the suggestions would result in mild improvements, but looks ok to me as-is
| time.sleep(context.options.cmd.loop_wait) | ||
|
|
||
|
|
||
| @when(u'you call {url} using the CloudFoundry OAuth token') |
There was a problem hiding this comment.
I think this belongs more towards the bottom of the file by the other CloudFoundry/OAuth methods and I'd prefer "with the CloudFoundry OAuth token" but neither is a blocker
There was a problem hiding this comment.
I have adapted the feature wording, but I don't understand what move you have in mind. The current order is:
- GET
- GET with token (new)
- POST
- POST uid/pwd
It looks fine to me, but if you disagree, please indicate how you'd like this changed.
| - To deploy local sources, run the following commands: | ||
|
|
||
| ```shell | ||
| dotnet build -t:WriteGitPropertiesFallbackFile |
There was a problem hiding this comment.
There's no indication here of what happens if this step is missed/skipped. IIRC the logs should give a pretty good indicator of what went wrong, so it shouldn't be necessary, but it wouldn't hurt to have a note spelling it out here.
There was a problem hiding this comment.
Can you provide a suggestion?
There was a problem hiding this comment.
On the other hand, there are many "magical" instructions that are not immediately obvious, which is why each readme ends with the following:
See the Official Steeltoe Management Documentation for more detailed information.
2 participants
No description provided.