Because of mysql 8.x reserved keys the SORTBY rank does not work any …#30
Open
dimitrihilverda wants to merge 1 commit intoSterc:developfrom
Open
Conversation
…more. replaced it with the queries alias like FormaliciousAnswer_rank etc.
Jako
reviewed
Jul 9, 2024
Jako
left a comment
Jako
left a comment
There was a problem hiding this comment.
I would change the underscore to a dot since that is the normal xPDO field syntax.
_rank => .rank
Otherwise I am fine with that PR.
Contributor
|
I am using MAMP with MySQL 8 for my local web server. Takes some time today for me to get the hint that this issue prevents the form from displaying. Would be good to merge this quickly 👍🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…more. replaced it with the queries alias like FormaliciousAnswer_rank etc.