Add instructions for using builder pattern#1
Open
friism wants to merge 3 commits intoSteveLasker:masterfrom
Open
Add instructions for using builder pattern#1friism wants to merge 3 commits intoSteveLasker:masterfrom
friism wants to merge 3 commits intoSteveLasker:masterfrom
Conversation
glennc
reviewed
Feb 23, 2017
| WORKDIR /app | ||
|
|
||
| ADD project.json . | ||
| RUN dotnet restore --no-cache |
There was a problem hiding this comment.
Is there a compelling reason to do --no-cache here? You are slowing down the restore for no real gain.
Author
There was a problem hiding this comment.
It's because I had misunderstood what the flag does: aspnet/MusicStore#713 (comment)
There was a problem hiding this comment.
Ah. That makes sense. Yeah, we probably should talk about clarifying the descriptions and such if it is still the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's too bad that it's so hard to do in PowerShell because of reasons.
In bash it would be something like: